fix(telemetry): make strands agent invoke_agent span as INTERNAL spanKind #1055
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting the
invoke_agentspan to INTERNAL spanKind to follow the semantic convention.It is arguable that
invoke_agentcan beCLIENTin an A2A scenario. However, sinceinvoke_agentis an internal process most of the time, we decided to set the spanKind toINTERNAL.Related Issues
#1044
Follow up Task
As mentioned, in the A2A world,
invoke_agentcould be CLIENT spanKind. We will decide whether to allow customer to pass the spanKind for strands agent to set directly, or to have a separate opinionated A2Ainvoke_agentwith CLIENT spanKind.Documentation PR
N/A
Type of Change
Bug fix
Breaking change
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.