Skip to content

Post 7.0 quick wins#238

Open
RachelRVasquez wants to merge 7 commits intostrangerstudios:devfrom
RachelRVasquez:post-7.0-quick-wins
Open

Post 7.0 quick wins#238
RachelRVasquez wants to merge 7 commits intostrangerstudios:devfrom
RachelRVasquez:post-7.0-quick-wins

Conversation

@RachelRVasquez
Copy link
Collaborator

@RachelRVasquez RachelRVasquez commented Mar 16, 2026

All Submissions:

Changes proposed in this Pull Request:

Tackles "quick wins" post 7.0 launch that we can merge/deploy pretty safely without having to wait for other features to be implemented:

  • Updated Github workflow so the /build folder is committed regardless of what the .gitignore says. It already has logic to avoid running npm ci if the package-lock.json is either not in the incoming merge or matches what's on master. This file isn't something that should ever change anyway unless we're updating/changing dependencies.
  • RTL: Chevron that points right in header sub-menus has been updated to point left for RTL languages
  • Mobile: Hamburger menu button had a border. That's been removed.
  • Color Schemes: Updated Cocoa Ash to dark scheme. Added another one called Gotham.
  • Widgets: Styling has been reviewed and updated if they looked off. Mostly the calendar widget. Added some minor styling to the sidebar itself.

How to test the changes in this Pull Request:

  1. Mobile: Confirm that the hamburger menu icon/button no longer has a border
  2. RTL: Switch your site to a RTL language and confirm that the header sub-menus now have arrows that point left
  3. Widgets: Set up widgets in the sidebar and/or footer and confirm if they look good. The calendar widget might go beyond the container depending on the "grid" that's been set from customizer. Since it's a table, there's only so "flexible" it can be so for the sidebar, I've applied a style of overflow: hidden to hide any run off from the calendar.
  4. Color Schemes: Check Cocoa Ash and Gotham schemes from Customizer. Are border colors, font colors, and links all readable?

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Improve navigation/UI behavior and styling (sticky nav border, mobile toggle border removal, RTL submenu chevron direction). Updated color schemes including one new one. Refined widget/footer/sidebar styling.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies a set of small post-7.0 theme “quick wins” focused on visual polish (typography/underlines, navigation, widgets), RTL correctness, and adding/updating color schemes, plus a workflow tweak to ensure built assets are committed.

Changes:

  • Standardize link underline styling (increase text-underline-offset to 3px) across multiple theme areas.
  • Improve navigation/UI behavior and styling (sticky nav border, mobile toggle border removal, RTL submenu chevron direction).
  • Update color schemes (adjust existing palettes, enable Cocoa Ash as a dark scheme, add Gotham) and refine widget/footer/sidebar styling.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/scss/structure/_masthead.scss Adjust underline offset for masthead links.
src/scss/structure/_header.scss Header/nav styling updates (underline offset, sticky border, member nav tweaks, mobile toggle border removal).
src/scss/structure/_footer.scss Footer widgets styling updates (overflow handling, calendar link color).
src/scss/structure/_content.scss Adjust underline offset for entry meta/footer links.
src/scss/components/_widgets.scss Sidebar/widget container restyling and calendar widget/block refinements.
src/scss/components/_grid-list.scss Adjust underline offset for grid/list links.
src/scss/components/_comments.scss Adjust underline offset for comment reply cancel link.
src/scss/base/_base.scss Global underline offset + list/table/pre styling tweaks.
src/scss/abstracts/_mixins.scss Form element base background update.
inc/custom-walkers.php RTL-aware chevron selection for nested submenu toggles.
inc/colors.php Update existing schemes, enable Cocoa Ash, add Gotham, adjust brightness helper formatting.
.github/workflows/build-theme-files.yml Force-add build/ to commits (bypass .gitignore).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RachelRVasquez RachelRVasquez marked this pull request as ready for review March 17, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants