Open
Conversation
…ticky nav, cocoa ash and gotham dark color schemes introduced
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies a set of small post-7.0 theme “quick wins” focused on visual polish (typography/underlines, navigation, widgets), RTL correctness, and adding/updating color schemes, plus a workflow tweak to ensure built assets are committed.
Changes:
- Standardize link underline styling (increase
text-underline-offsetto3px) across multiple theme areas. - Improve navigation/UI behavior and styling (sticky nav border, mobile toggle border removal, RTL submenu chevron direction).
- Update color schemes (adjust existing palettes, enable Cocoa Ash as a dark scheme, add Gotham) and refine widget/footer/sidebar styling.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/scss/structure/_masthead.scss |
Adjust underline offset for masthead links. |
src/scss/structure/_header.scss |
Header/nav styling updates (underline offset, sticky border, member nav tweaks, mobile toggle border removal). |
src/scss/structure/_footer.scss |
Footer widgets styling updates (overflow handling, calendar link color). |
src/scss/structure/_content.scss |
Adjust underline offset for entry meta/footer links. |
src/scss/components/_widgets.scss |
Sidebar/widget container restyling and calendar widget/block refinements. |
src/scss/components/_grid-list.scss |
Adjust underline offset for grid/list links. |
src/scss/components/_comments.scss |
Adjust underline offset for comment reply cancel link. |
src/scss/base/_base.scss |
Global underline offset + list/table/pre styling tweaks. |
src/scss/abstracts/_mixins.scss |
Form element base background update. |
inc/custom-walkers.php |
RTL-aware chevron selection for nested submenu toggles. |
inc/colors.php |
Update existing schemes, enable Cocoa Ash, add Gotham, adjust brightness helper formatting. |
.github/workflows/build-theme-files.yml |
Force-add build/ to commits (bypass .gitignore). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Tackles "quick wins" post 7.0 launch that we can merge/deploy pretty safely without having to wait for other features to be implemented:
/buildfolder is committed regardless of what the.gitignoresays. It already has logic to avoid runningnpm ciif thepackage-lock.jsonis either not in the incoming merge or matches what's onmaster. This file isn't something that should ever change anyway unless we're updating/changing dependencies.How to test the changes in this Pull Request:
overflow: hiddento hide any run off from the calendar.Other information:
Changelog entry