Skip to content

feat(upload): add documentation for new setting #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Tyki
Copy link

@Tyki Tyki commented Mar 27, 2025

What does it do?

This pull request add a new settings to limit the concurrency of uploads to 1 in the media library.

It also fix a small issue when the file size is checked only after that images optimizations are applied. But it means that, whatever the image size is, sharp will try to optimize it. On low ram environments, it leads to OOM.

How to test it?

Add the new setting in the configuration for the upload plugin: limitConcurrentUpload

  upload: {
    config: {
      limitConcurrentUploads: true
    }
  },

and then try to upload multiple assets in the same time

Related issue(s)/PR(s)

strapi/strapi#23253

@Tyki Tyki requested a review from meganelacheny as a code owner March 27, 2025 20:36
@strapi-cla
Copy link

strapi-cla commented Mar 27, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

vercel bot commented Mar 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2025 8:46pm

@pwizla
Copy link
Collaborator

pwizla commented Mar 31, 2025

Thank you, @Tyki!
The PR is approved, but I'll wait for the corresponding strapi/strapi PR to be merged before merging the present PR (hence the flag: merge pending release—it will make some test fail to ensure it's not merged prematurely)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants