Monkeytype

[mulkieran]

Related stratis-storage/project#89

[mulkieran]

Somewhat inscrutable error:

ModuleNotFoundError: No module named 'pyparsing.results'; 'pyparsing' is not a package

Inscrutable because pyparsing is definitely installed, etc. The usual cause is a name conflict, but I'm not aware that I'm inserting any pyparsing thing anywhere.

[mulkieran]

Aaah, and the failure is only on our "lowest developement environment", fedora 35, which means it could be a problem with the library. Not locally reproducible, presumably due to newer Fedora.

[mulkieran]

Should work on adding support for apply step to hs-dbus-signature.

[mulkieran]

We could make this part of CI...how?

[mulkieran]

Problem here is that there is a sequence of steps:

• run tests profiling with monkeytype (Makefile target)
• apply changes (Makefile target)
• fmt all (since changes may require formatting)
• run linter (to see if anything is wrong)

We can do that all in nightly CI w/out difficulty, but it is not a single step so would be mean to impose on developer all the time. On the other hand, the developer may make a change that requires or results in an update to a type. So we need to add a shell script for them...and then, how to use exactly?

This can fail in a number of places:

1. Tests fail during profiling. Do they want to stop devel and fix it? No, they want to ignore it.
2. apply changes with an overwrite is best here
3. fmt should work
4. linter may reject, more or less correctly, due to the types being concrete and dynamic. Again, the developer does not want to have to deal with this.

[mulkieran]

Another problem monkeytype has is that it needs extra help finding the pip install path to use. the simple Makefile 'test' target does not require that the PYTHONPATH be set, but the monkeytype test target does.

[mulkieran]

And, a problem for this project, I suspect that the order of types in a Union type are determined by the frequency of their occurrence within a call trace. So, if the majority of one's test suite is not deterministic in its choice of tests, the order of types in a Union type will flip around.