Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sv1 mining device tweaks #1485

Merged

Conversation

jbesraa
Copy link
Contributor

@jbesraa jbesraa commented Feb 13, 2025

resolves #1484
highest priority from my side as it blocks a couple of MG tests migration

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.27%. Comparing base (bec1d3e) to head (96764a1).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1485      +/-   ##
==========================================
- Coverage   18.28%   18.27%   -0.02%     
==========================================
  Files         127      127              
  Lines        9738     9738              
==========================================
- Hits         1781     1780       -1     
- Misses       7957     7958       +1     
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_sv2-coverage 6.95% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 24.88% <ø> (ø)
codec_sv2-coverage 0.02% <ø> (ø)
common_messages_sv2-coverage 0.17% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.37% <ø> (ø)
jd_client-coverage 0.42% <ø> (ø)
jd_server-coverage 12.98% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.38% <ø> (ø)
mining-coverage 3.15% <ø> (-0.03%) ⬇️
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.82% <ø> (ø)
noise_sv2-coverage 5.78% <ø> (ø)
protocols 23.89% <ø> (-0.02%) ⬇️
roles 7.71% <ø> (ø)
roles_logic_sv2-coverage 11.62% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.53% <ø> (ø)
utils 25.04% <ø> (ø)
v1-coverage 3.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbesraa jbesraa force-pushed the 2025-02-13/sv1-mining-device-tweaks branch from 9972955 to 087d432 Compare February 13, 2025 11:24
@jbesraa jbesraa force-pushed the 2025-02-13/sv1-mining-device-tweaks branch 2 times, most recently from 529267a to 6c0b175 Compare February 16, 2025 13:29
@jbesraa jbesraa mentioned this pull request Feb 17, 2025
@jbesraa jbesraa force-pushed the 2025-02-13/sv1-mining-device-tweaks branch from 1bc12b1 to 3a0b65f Compare February 17, 2025 16:30
@GitGab19 GitGab19 merged commit 84c0f2c into stratum-mining:main Feb 25, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sv1 mining device channels fix and new flag
4 participants