Skip to content

Bump windows-core to 0.53-0.54 range #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged

Bump windows-core to 0.53-0.54 range #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bad558
WIP: Bump MSRV to 1.62
MarijnS95 Mar 25, 2025
a26e540
Bump `windows-core` to `0.53-0.54` range
MarijnS95 Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .clippy.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
avoid-breaking-exported-api = true
msrv = "1.61.0"
msrv = "1.62.0"
20 changes: 10 additions & 10 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,16 @@ jobs:
matrix:
runs-on: [ubuntu-22.04, windows-2022, macos-13]
toolchain:
- "1.61"
- "1.62"
- stable
- nightly
versions:
- ""
- "-Zminimal-versions"
exclude:
# package `regex v1.11.1` cannot be built because it requires rustc
# 1.65 or newer, while the currently active rustc version is 1.61.0
- toolchain: "1.61"
# 1.65 or newer, while the currently active rustc version is 1.62.0
- toolchain: "1.62"
versions: ""
runs-on: ${{ matrix.runs-on }}
steps:
Expand Down Expand Up @@ -61,7 +61,7 @@ jobs:
include:
# Without `-Zminimal-versions` a too recent bumpalo version is selected. Newer versions use `edition = "2021"`.
- versions: "-Zminimal-versions"
- toolchain: "1.61"
- toolchain: "1.62"
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand Down Expand Up @@ -186,7 +186,7 @@ jobs:
fail-fast: false
matrix:
toolchain:
- "1.61"
- "1.62"
- stable
target:
- x86_64-apple-ios
Expand All @@ -195,8 +195,8 @@ jobs:
- "-Zminimal-versions"
exclude:
# package `regex v1.11.1` cannot be built because it requires rustc
# 1.65 or newer, while the currently active rustc version is 1.61.0
- toolchain: "1.61"
# 1.65 or newer, while the currently active rustc version is 1.62.0
- toolchain: "1.62"
versions: ""
runs-on: macos-13
steps:
Expand All @@ -221,16 +221,16 @@ jobs:
fail-fast: false
matrix:
toolchain:
- "1.61"
- "1.62"
- stable
- nightly
versions:
- ""
- "-Zminimal-versions"
exclude:
# package `cc v1.2.17` cannot be built because it requires rustc 1.63
# or newer, while the currently active rustc version is 1.61.0
- toolchain: "1.61"
# or newer, while the currently active rustc version is 1.62.0
- toolchain: "1.62"
versions: ""
runs-on: ubuntu-latest
env:
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Unreleased
### Changes
- Bump MSRV (minimum supported rust version) to 1.62 ([#131](https://github.com/strawlab/iana-time-zone/pull/131))
- Bump `windows-core` to `0.53-0.54` range ([#131](https://github.com/strawlab/iana-time-zone/pull/131))

## [0.1.62] - 2025-03-24
### Changed
- Bump MSRV (minimum supported rust version) to 1.61 ([#157](https://github.com/strawlab/iana-time-zone/pull/157))
Expand Down
4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ keywords = ["IANA", "time"]
categories = ["date-and-time", "internationalization", "os"]
readme = "README.md"
edition = "2021"
rust-version = "1.61.0"
rust-version = "1.62.0"

[features]
# When enabled, the library will succeed to compile for unknown target platforms, and return an `Err(GetTimezoneError::OsError)` at runtime.
Expand All @@ -26,7 +26,7 @@ android_system_properties = "0.1.5"
core-foundation-sys = "0.8.6"

[target.'cfg(target_os = "windows")'.dependencies]
windows-core = { version = ">=0.50, <=0.52" }
windows-core = { version = ">=0.53, <=0.54" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we able to lower the bound on this so we can get the crate building with Rust 1.61.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me do some experimentation to see how far we can stretch this bound without bumping the generator and hence requirements for MSRV/edition, and keep separate PRs open when we do end up bumping those.

Copy link
Contributor Author

@MarijnS95 MarijnS95 Mar 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.53 already requires MSRV 1.62, the resulting compatibility issues with older windows-bindgen output don't even matter at that point.


[target.'cfg(all(target_arch = "wasm32", target_os = "unknown"))'.dependencies]
js-sys = "0.3.66"
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ cargo run --example get_timezone

## Minimum supported rust version policy

This crate has a minimum supported rust version (MSRV) of 1.61.0 for [Tier 1]
This crate has a minimum supported rust version (MSRV) of 1.62.0 for [Tier 1]
platforms.

[tier 1]: https://doc.rust-lang.org/1.61.0/rustc/platform-support.html
[tier 1]: https://doc.rust-lang.org/1.62.0/rustc/platform-support.html

Updates to the MSRV are sometimes necessary due to the MSRV of dependencies.
MSRV updates will not be indicated as a breaking change to the semver version.
Expand Down
9 changes: 5 additions & 4 deletions api_gen/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
[package]
name = "api_gen"
version = "0.0.0"
edition = "2018"
edition = "2021"
publish = false

[dependencies]
windows-bindgen = "0.51"
windows-bindgen = "0.54"

# Dissociate this crate from the root workspace to allow older Rust to build the main crate within
# the workspace, without observing `edition = "2021"` inside `windows-bindgen`.
# Dissociate this crate from the root workspace to allow older Rust to build
# the main crate within the workspace, without observing higher `rust-version`
# requirements inside `windows-bindgen` and its dependencies.
[workspace]
Loading
Loading