Port Main Window to React - #4853
Merged
Merged
Conversation
BundleMonFiles updated (2)
Unchanged files (2)
Total files change -15.21KB -0.12% Final result: ✅ View report in BundleMon website ➡️ |
blackxored
approved these changes
Apr 23, 2025
| )} | ||
| </div> | ||
| {(!ctrl.platform || | ||
| (isPlatform(['youtube', 'facebook', 'twitter', 'tiktok', 'kick']) && !isStreaming)) && ( |
Contributor
There was a problem hiding this comment.
not really a comment, but a note to self, lots of isPlatform evaluations over here, most of the time with the same arguments, that should probably be extracted in the future. It will make it easier to support newer platforms as well instead of having to track all these instances
Contributor
Author
There was a problem hiding this comment.
i think that's slightly out of scope for this PR but yes agreed, i have a thought to handle this similar how we use hasCapability for platform features
Contributor
Author
There was a problem hiding this comment.
made a follow up PR here for when this is merged
#5401
michelinewu
approved these changes
May 7, 2025
Contributor
Author
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.