[highlighter] - new games and import flow #5347
Conversation
|
|
# Conflicts: # app/i18n/en-US/highlighter.json
| } else { | ||
| callback(); | ||
| } | ||
| } |
There was a problem hiding this comment.
not blocking but there is actually a cleaner way to do this if the validation is just a regex match like this:
const specialCharacterValidator = {
pattern: /[\\/:"*?<>|]+/g,
message: $t('You cannot use special characters in this field'),
}
...
<Input rules={[specialCharacterValidator]} />
| setDraggingOver(true); | ||
| }} | ||
| onDrop={e => { | ||
| console.log(e.dataTransfer.files); |
| style={ | ||
| { | ||
| '--border-style': filePath ? 'solid' : 'dashed', | ||
| '--border-color': draggingOver ? 'var(--teal)' : 'var(--midtone)', |
There was a problem hiding this comment.
do borderStyle and borderColor not work here?
| objectFit: 'cover', | ||
| borderRadius: '2px', | ||
| }} | ||
| onError={e => { |
There was a problem hiding this comment.
when are we expecting this to happen?
| background-color: #232d3530; | ||
| border-radius: 22px; | ||
| margin-top: 8px; | ||
| } |
There was a problem hiding this comment.
while global styles should be wrapped in a scoped class we generally want to avoid that for other scoped classes as it impacts performance when painting frames
| ) : ( | ||
| <> | ||
| <span style={{ fontWeight: 700 }}>Ai Highlighter requirements</span> | ||
| <span style={{ fontWeight: 700 }}>AI Highlighter requirements</span> |
| @@ -423,6 +420,19 @@ export class HighlighterService extends PersistentStatefulService<IHighlighterSt | |||
| title: this.streamingService.views.settings.platforms.twitch?.title, | |||
| game, | |||
| }; | |||
|
|
|||
| // console.log('recording Alreadyt running?:', this.streamingService.views.isRecording); | |||
| }); | ||
|
|
||
| if (this.streamingService.views.isRecording) { | ||
| // console.log('Recording is already running'); |
| }); | ||
| }) | ||
| .catch(error => { | ||
| console.error('Failed getting duration right after the recoding.', error); | ||
| }); | ||
|
|
||
| aiRecordingInProgress = false; | ||
| this.detectAndClipAiHighlights(path, streamInfo, true); | ||
| // this.detectAndClipAiHighlights(path, streamInfo, true); |
| WARZONE = 'warzone', | ||
| MARVEL_RIVALS = 'marvel_rivals', | ||
| WAR_THUNDER = 'war_thunder', | ||
| VALORANT = 'valorant', |
There was a problem hiding this comment.
just fyi the enum values can have spaces in them, might be useful for the switch in highlighter/index.ts
No description provided.