Skip to content

Fix highlighter recording broken by twitch game_id instead of game_name - #5949

Merged
gettinToasty merged 1 commit into
masterfrom
highlighter/jk-fix-highlighter-recording
May 29, 2026
Merged

gettinToasty merged 1 commit into
masterfrom
highlighter/jk-fix-highlighter-recording

Conversation

@jankalthoefer

Copy link
Copy Markdown
Contributor

With a previous change the this.streamingService.views.game now passes a game_id instead of the game_name.
I now added the game_name as an additional views variable to the streamingService, which is only used in the highlighterService now.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes AI Highlighter recording/analytics behavior when Twitch streaming settings began supplying a game_id instead of a human-readable game name.

Changes:

  • Added StreamInfoView.gameName to expose a name-based game value (notably for Twitch).
  • Updated HighlighterService to use streamingService.views.gameName for analytics and game support checks.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
app/services/streaming/streaming-view.ts Adds a gameName view getter intended to return a human-readable game name (used by Highlighter).
app/services/highlighter/index.ts Switches Highlighter analytics + support checks from views.game to views.gameName.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/services/streaming/streaming-view.ts
Comment thread app/services/highlighter/index.ts
@bundlemon

bundlemon Bot commented May 28, 2026

Copy link
Copy Markdown

BundleMon

Files updated (1)
Status Path Size Limits
renderer.(hash).js
7.77MB (+359B 0%) -
Unchanged files (3)
Status Path Size Limits
vendors~renderer.(hash).js
4.67MB -
updater.js
115.29KB -
guest-api.js
40.23KB -

Total files change +359B 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@jankalthoefer
jankalthoefer force-pushed the highlighter/jk-fix-highlighter-recording branch from d9d1fd8 to 6471f69 Compare May 28, 2026 10:38
Comment thread app/services/streaming/streaming-view.ts
@jankalthoefer
jankalthoefer force-pushed the highlighter/jk-fix-highlighter-recording branch from 6471f69 to c8db652 Compare May 29, 2026 06:04
@gettinToasty
gettinToasty merged commit e486f69 into master May 29, 2026
15 checks passed
@gettinToasty
gettinToasty deleted the highlighter/jk-fix-highlighter-recording branch May 29, 2026 20:03
gettinToasty added a commit that referenced this pull request May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants