Fix highlighter recording broken by twitch game_id instead of game_name - #5949
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes AI Highlighter recording/analytics behavior when Twitch streaming settings began supplying a game_id instead of a human-readable game name.
Changes:
- Added
StreamInfoView.gameNameto expose a name-based game value (notably for Twitch). - Updated
HighlighterServiceto usestreamingService.views.gameNamefor analytics and game support checks.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| app/services/streaming/streaming-view.ts | Adds a gameName view getter intended to return a human-readable game name (used by Highlighter). |
| app/services/highlighter/index.ts | Switches Highlighter analytics + support checks from views.game to views.gameName. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BundleMonFiles updated (1)
Unchanged files (3)
Total files change +359B 0% Final result: ✅ View report in BundleMon website ➡️ |
jankalthoefer
force-pushed
the
highlighter/jk-fix-highlighter-recording
branch
from
May 28, 2026 10:38
d9d1fd8 to
6471f69
Compare
jankalthoefer
commented
May 28, 2026
jankalthoefer
force-pushed
the
highlighter/jk-fix-highlighter-recording
branch
from
May 29, 2026 06:04
6471f69 to
c8db652
Compare
gettinToasty
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a previous change the
this.streamingService.views.gamenow passes a game_id instead of the game_name.I now added the game_name as an additional views variable to the streamingService, which is only used in the highlighterService now.