New Crowdin updates - #6131
Merged
Merged
New Crowdin updates#6131
Conversation
[ci skip]
[ci skip]
[ci skip]
Contributor
There was a problem hiding this comment.
Pull request overview
Updates localized filter-name string maps to include newly introduced NVIDIA filter labels across multiple languages, keeping the i18n dictionaries in sync with the base (en-US) keys.
Changes:
- Added a new filter label key for
"NVIDIA Audio Effects"in each locale’sfilters.json. - Added new filter label keys for
"NVIDIA Blur Filter"and"NVIDIA Background Blur Filter"in each locale’sfilters.json.
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app/i18n/zh-TW/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for zh-TW. |
| app/i18n/zh-CN/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for zh-CN. |
| app/i18n/vi-VN/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for vi-VN. |
| app/i18n/tr-TR/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for tr-TR. |
| app/i18n/th-TH/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for th-TH. |
| app/i18n/sv-SE/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for sv-SE. |
| app/i18n/sl-SI/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for sl-SI. |
| app/i18n/sk-SK/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for sk-SK. |
| app/i18n/ru-RU/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for ru-RU. |
| app/i18n/pt-PT/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for pt-PT. |
| app/i18n/pt-BR/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for pt-BR. |
| app/i18n/pl-PL/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for pl-PL. |
| app/i18n/nl-NL/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for nl-NL. |
| app/i18n/mk-MK/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for mk-MK. |
| app/i18n/ko-KR/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for ko-KR. |
| app/i18n/ja-JP/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for ja-JP. |
| app/i18n/it-IT/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for it-IT. |
| app/i18n/id-ID/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for id-ID. |
| app/i18n/hu-HU/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for hu-HU. |
| app/i18n/fr-FR/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for fr-FR. |
| app/i18n/es-ES/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for es-ES. |
| app/i18n/de-DE/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for de-DE. |
| app/i18n/da-DK/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for da-DK. |
| app/i18n/cs-CZ/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for cs-CZ. |
| app/i18n/ar-SA/filters.json | Adds NVIDIA Audio Effects + NVIDIA blur filter label keys for ar-SA. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
[ci skip]
[ci skip]
[ci skip]
[ci skip]
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 75 out of 75 changed files in this pull request and generated no new comments.
Suppressed comments (2)
Previously missed (2) — in code that hasn't changed since the last review.
app/i18n/es-ES/settings.json:259
- This key/value was added to this locale, but it does not exist in the canonical source locale (app/i18n/en-US/settings.json) and the string doesn’t appear to be referenced anywhere in the repo. That combination usually indicates an orphaned / accidentally-exported translation entry; consider either (1) adding the key to en-US and wiring it up where it’s used, or (2) removing it from locale files until the feature lands to avoid drift between locales.
"Failed to update the video resolution.": "Failed to update the video resolution.",
app/i18n/es-ES/scenes.json:35
- This new scene-collection upgrade warning string is present in multiple non-en-US locales, but it’s missing from app/i18n/en-US/scenes.json and the text doesn’t appear to be referenced anywhere in the repo. Please either add it to en-US (and ensure it’s actually used), or remove it from locale files until the feature/codepath exists, to keep locale catalogs in sync.
"This scene collection could not be upgraded. To prevent data loss, changes to it will not be saved until it can be loaded completely.": "This scene collection could not be upgraded. To prevent data loss, changes to it will not be saved until it can be loaded completely.",
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 75 out of 75 changed files in this pull request and generated 2 comments.
Suppressed comments (2)
Previously missed (1) — in code that hasn't changed since the last review.
app/i18n/fr-FR/filters.json:15
- This newly added filter name is currently not localized for fr-FR (English value). If the intent is to localize descriptive parts of NVIDIA filter names (as with "NVIDIA Background Removal"), this should be translated as well.
This issue also appears on line 31 of the same file.
"NVIDIA Audio Effects": "NVIDIA Audio Effects",
app/i18n/fr-FR/filters.json:32
- In this locale file, the newly introduced filter name remains in English while other NVIDIA filter names here are localized (e.g., "NVIDIA Background Removal"). This creates inconsistent localization in the Filters UI.
"NVIDIA Blur Filter": "NVIDIA Blur Filter",
"NVIDIA Background Blur Filter": "NVIDIA Background Blur Filter",
| "FPS Denominator": "Dénominateur de FPS", | ||
| "FPS Value": "Valeur de FPS", | ||
| "The resolution must be in the format [width]x[height] (i.e. 1920x1080)": "La résolution doit être au format [largeur] x [hauteur] (par exemple, 1920 x 1080)", | ||
| "Failed to update the video resolution.": "Failed to update the video resolution.", |
| "Rename Folder": "Renommer le dossier", | ||
| "Name Folder": "Nommer le dossier", | ||
| "Failed to load scene collection. A new one will be created instead.": "Échec du chargement de la collection de scènes. Une nouvelle scène sera créée.", | ||
| "This scene collection could not be upgraded. To prevent data loss, changes to it will not be saved until it can be loaded completely.": "This scene collection could not be upgraded. To prevent data loss, changes to it will not be saved until it can be loaded completely.", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.