Fix onboarding test

[sandboxcoder]

Remove verification of DualOutputToggle.tsx elements that is not displayed on the EOnboardingSteps.HardwareSetup page

Now this command will pass:

yarn test:file test-dist/test/regular/onboarding.js

[Copilot]

Pull request overview

This PR updates the onboarding E2E tests to stop asserting on DualOutputToggle.tsx UI elements that aren’t shown during the EOnboardingSteps.HardwareSetup step, preventing false failures in the onboarding flow tests.

Changes:

• Removed dual-output-inactive visibility assertions from multiple onboarding test cases where the toggle isn’t displayed.
• Kept existing source/scene assertions (e.g., confirmDefaultSources) as the primary validation for onboarding outcomes.

Suppressed comments (2)

test/regular/onboarding.ts:290

• This test calls confirmDefaultSources(...CheckOverlaySources), which does not validate dual vs single output; it checks source state for an overlay install. Update the comment so it doesn’t claim to verify “dual output status”.

    await finishOnboarding(installTheme);
    // Confirm sources and dual output status
    await confirmDefaultSources(t, DefaultSourcesCheck.CheckOverlaySources);

test/regular/onboarding.ts:306

• This branch asserts there should be no default sources (DefaultSourcesCheck.NoDefaultSources), but the comment mentions “default sources and dual output status”. Update the comment to match the actual check.

    // Confirm switched to scene with default sources and dual output status
    await confirmDefaultSources(t, DefaultSourcesCheck.NoDefaultSources);

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[bundlemon]

BundleMon

Unchanged files (4)

Status	Path	Size	Limits
✅	renderer.(hash).js	10.32MB	-
✅	vendors~renderer.(hash).js	4.67MB	-
✅	updater.js	115.29KB	-
✅	guest-api.js	40.23KB	-

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️

---

Current branch size history | Target branch size history

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

test/regular/onboarding.ts:249

• The comment says “Confirm sources”, but this block still asserts on the dual-output-inactive icon. This is inconsistent with the updated intent of removing DualOutputToggle checks (and will likely fail if this skipped test is re-enabled). Remove the dual output assertion or update the comment to match.

    // Confirm sources
    t.not(await getNumElements('div[data-role=source]'), 0, 'Theme installed before login');
    t.true(await isDisplayed('i[data-testid=dual-output-inactive]'), 'Single output enabled');