Fixed saving non-common encoder settings - #6163
Open
aleksandr-voitenko wants to merge 3 commits into
Open
Conversation
BundleMonFiles added (4)
Total files change +15.35MB Final result: ✅ View report in BundleMon website ➡️ |
aleksandr-voitenko
force-pushed
the
fix-encoder-settings
branch
from
September 9, 2026 05:17
45b5a74 to
31ddf97
Compare
michelinewu
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
streamlabs/obs-studio-node#1770
Motivation
Users could save encoder settings in the UI without those settings reaching the encoder. This caused recordings to ignore the selected keyframe interval and Advanced audio tracks to use 160 Kbps despite a configured bitrate of 320 Kbps. Streaming also lost settings such as encoder presets and profiles.
The issue originated during the Factory API migration. Settings continued to persist through the existing settings API, while Desktop passed only selected video properties to Factory-created encoders and hardcoded audio track settings. A subsequent recording fix restored bitrate and rate control but left other properties missing.
Description
This change depends on OSN PR #1770, which exposes saved encoder settings and supports replacing user settings on inactive encoders. Desktop supplies these settings explicitly, preserving native encoder defaults and existing output policies.
Registered audio tracks are updated in place so outputs retain valid references. Retained video encoders receive current settings before reuse.
Tests inspect native objects and use
ffprobeto verify keyframe spacing and audio bitrates in local recordings.Changes