Skip to content

feat: Expose additive_vpc_scope_dns_domain #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2025
Merged

feat: Expose additive_vpc_scope_dns_domain #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d84463
Expose additive_vpc_scope_dns_domain
ciiiii Oct 31, 2025
a6c9d2b
Upgrade upstream module version
ciiiii Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ locals {
module "gke" {
count = var.enable_private_gke ? 0 : 1
source = "terraform-google-modules/kubernetes-engine/google"
version = "33.1.0"
version = "35.0.1"

name = var.cluster_name
add_cluster_firewall_rules = var.add_cluster_firewall_rules
Expand Down Expand Up @@ -194,6 +194,7 @@ module "gke" {
cluster_dns_provider = var.cluster_dns_provider
cluster_dns_scope = var.cluster_dns_scope
cluster_dns_domain = var.cluster_dns_domain
additive_vpc_scope_dns_domain = var.additive_vpc_scope_dns_domain
}

module "gke_private" {
Expand Down
8 changes: 7 additions & 1 deletion variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,12 @@ variable "cluster_dns_domain" {
default = ""
}

variable "additive_vpc_scope_dns_domain" {
type = string
description = "This will enable Cloud DNS additive VPC scope. Must provide a domain name that is unique within the VPC. For this to work cluster_dns = `CLOUD_DNS` and cluster_dns_scope = `CLUSTER_SCOPE` must both be set as well."
default = ""
}

variable "cluster_http_load_balancing" {
default = true
description = "Enable the HTTP load balancing addon for the cluster. Defaults to \"true\""
Expand Down Expand Up @@ -507,4 +513,4 @@ variable "enable_l4_ilb_subsetting" {
type = bool
description = "Enable L4 ILB Subsetting on the cluster, this cannot be disabled once it has been enabled."
default = false
}
}
Loading