Skip to content

build(hub-contracts): fully automated deploy script #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 19, 2025

Conversation

jtakalai
Copy link
Contributor

replace in-between manual config update step

@jtakalai jtakalai requested review from Copilot, harbu and teogeb June 18, 2025 10:01
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Automates the deployment workflow by adding new chain support, environment overrides, and a wrapper script

  • Add dev2 and iotex chains with corresponding domain IDs and RPC URLs
  • Modify deploy scripts to accept an optional PROJECT_REGISTRY_ADDRESS override and write output files
  • Introduce a deployHubContracts.sh wrapper for fully automated multi-step deployment

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/hub-contracts/utils.ts Added dev2/iotex to chain lists and provided domain/RPC data
packages/hub-contracts/scripts/deployProjectStakingV1.ts Support PROJECT_REGISTRY_ADDRESS override and OUTPUT_FILE write
packages/hub-contracts/scripts/deployMarketplaceV4.ts Support PROJECT_REGISTRY_ADDRESS override and add error handling
packages/hub-contracts/scripts/deployHubContracts.sh New wrapper script to chain all deploy commands
packages/hub-contracts/hardhat.config.ts Added dev2 and iotex network configurations
Comments suppressed due to low confidence (1)

packages/hub-contracts/scripts/deployMarketplaceV4.ts:54

  • [nitpick] You may want to wait for the role-grant transaction to be mined before logging success, e.g. await (await projectRegistry.grantRole(...)).wait().
    await projectRegistry.grantRole(id("TRUSTED_ROLE"), marketplace.address)

replace in-between manual config update step
@jtakalai jtakalai force-pushed the hub-contract-deploy-script-fix branch from 03458e4 to c5eab66 Compare June 18, 2025 10:04
@jtakalai jtakalai merged commit 9ab6b77 into main Jun 19, 2025
3 checks passed
@jtakalai jtakalai deleted the hub-contract-deploy-script-fix branch June 19, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants