Introduce Helm Chart unit tests #10192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scholzj
reviewed
Jun 4, 2024
There was a problem hiding this comment.
Thanks for the PR @maciej-tatarski. I think it looks good, I have just some minor comments:
- Maybe you can link it from the main
Makefile? Add something like this: https://github.com/strimzi/strimzi-kafka-operator/blob/main/Makefile#L170-L171 for thehelm_unittesttarget as well? - I appreciate the GitHub workflow. But I think we will want to plug it into our Azure pipelines workflow to have it run also during releases etc. So I think you can remove the GitHub workflow for it. I'm happy to add it to the Azure pipeline myself in a follow up PR.
- I think the initial tests are completely fine. It is hard to add tests for everything out of the box. But once we have it, it will be much easier to add tests for any new features.
- Could you please add some note about the installation of the Helm plugin to https://github.com/strimzi/strimzi-kafka-operator/blob/main/development-docs/DEV_GUIDE.md#build-pre-requisites for any new contributors? I think just mentioning the plugin and sharing the installation command should be sufficient.
Thanks!
|
/azp run helm-acceptance |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@scholzj I applied all the suggestions :) |
|
/azp run helm-acceptance |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ppatierno
approved these changes
Jun 5, 2024
|
Thanks for the PR @maciej-tatarski |
pandurangkhandeparker
added a commit
to pandurangkhandeparker/strimzi-kafka-operator
that referenced
this pull request
Jun 10, 2024
Signed-off-by: Pandurang Khandeparker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Adding unit tests for helm charts.
Checklist