Skip to content

docs(logging): log4j2 support updates #11254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 26, 2025

Conversation

PaulRMellor
Copy link
Contributor

@PaulRMellor PaulRMellor commented Mar 11, 2025

Documentation

Updates the logging content to reflect new support and Kafka 4.0 adoption of log4j2

  • Removes/updates references to log4j1 and log4j1 logger names
  • Updates logging content in the deploying guide
    • Refreshes logging config overview
  • streamlines logging information in API reference guide to remove repetition

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@PaulRMellor PaulRMellor added this to the 0.46.0 milestone Mar 11, 2025
@PaulRMellor
Copy link
Contributor Author

Thanks for the comments @fvaleri
I've updated the examples as directed.
I've also updated the section on adding logging filters (appenders) based on your feedback.

Copy link
Contributor

@fvaleri fvaleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@PaulRMellor
Copy link
Contributor Author

Thanks @scholzj
I've returned to the logger sectiond in the API guide and made the preconfigured logger lists consistent with the change suggested for the bridge.
I've split the examples so the custom loggers are separate.

Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, being away from work, I do not have really enough time to focus on the PR all at once. So there is always a bunch of new things I notice with every pass. I imagine it must be hard to keep changing things again and again. Sorry :-(.

@PaulRMellor
Copy link
Contributor Author

Thanks for considering how to make the content clearer @scholzj
I've separated the inline and external examples, moving the descriptions to introduce each separately

Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more nits, but LGTM otherwise. I already approved it.

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a nit from me (and of course agree with the ones raised by Jakub)

@scholzj scholzj merged commit 0514641 into strimzi:main Mar 26, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants