-
Notifications
You must be signed in to change notification settings - Fork 1.4k
docs(logging): log4j2 support updates #11254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: prmellor <[email protected]>
documentation/api/io.strimzi.api.kafka.model.connect.KafkaConnectSpec.adoc
Outdated
Show resolved
Hide resolved
documentation/api/io.strimzi.api.kafka.model.connect.KafkaConnectSpec.adoc
Outdated
Show resolved
Hide resolved
documentation/api/io.strimzi.api.kafka.model.kafka.KafkaClusterSpec.adoc
Outdated
Show resolved
Hide resolved
documentation/api/io.strimzi.api.kafka.model.kafka.KafkaClusterSpec.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/operators/ref-operator-cluster-logging-configmap.adoc
Show resolved
Hide resolved
Signed-off-by: prmellor <[email protected]>
Thanks for the comments @fvaleri |
documentation/api/io.strimzi.api.kafka.model.bridge.KafkaBridgeSpec.adoc
Outdated
Show resolved
Hide resolved
documentation/api/io.strimzi.api.kafka.model.bridge.KafkaBridgeSpec.adoc
Outdated
Show resolved
Hide resolved
documentation/api/io.strimzi.api.kafka.model.bridge.KafkaBridgeSpec.adoc
Outdated
Show resolved
Hide resolved
documentation/api/io.strimzi.api.kafka.model.connect.KafkaConnectSpec.adoc
Show resolved
Hide resolved
documentation/api/io.strimzi.api.kafka.model.connect.KafkaConnectSpec.adoc
Outdated
Show resolved
Hide resolved
documentation/api/io.strimzi.api.kafka.model.kafka.KafkaClusterSpec.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: prmellor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
documentation/api/io.strimzi.api.kafka.model.bridge.KafkaBridgeSpec.adoc
Outdated
Show resolved
Hide resolved
documentation/api/io.strimzi.api.kafka.model.bridge.KafkaBridgeSpec.adoc
Outdated
Show resolved
Hide resolved
documentation/api/io.strimzi.api.kafka.model.connect.KafkaConnectSpec.adoc
Outdated
Show resolved
Hide resolved
documentation/api/io.strimzi.api.kafka.model.kafka.KafkaClusterSpec.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: prmellor <[email protected]>
Signed-off-by: prmellor <[email protected]>
documentation/api/io.strimzi.api.kafka.model.kafka.KafkaClusterSpec.adoc
Outdated
Show resolved
Hide resolved
documentation/api/io.strimzi.api.kafka.model.kafka.KafkaClusterSpec.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: prmellor <[email protected]>
Thanks @scholzj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, being away from work, I do not have really enough time to focus on the PR all at once. So there is always a bunch of new things I notice with every pass. I imagine it must be hard to keep changing things again and again. Sorry :-(.
documentation/api/io.strimzi.api.kafka.model.bridge.KafkaBridgeSpec.adoc
Outdated
Show resolved
Hide resolved
documentation/api/io.strimzi.api.kafka.model.connect.KafkaConnectSpec.adoc
Outdated
Show resolved
Hide resolved
documentation/api/io.strimzi.api.kafka.model.connect.KafkaConnectSpec.adoc
Outdated
Show resolved
Hide resolved
documentation/api/io.strimzi.api.kafka.model.kafka.KafkaClusterSpec.adoc
Outdated
Show resolved
Hide resolved
documentation/api/io.strimzi.api.kafka.model.kafka.KafkaClusterSpec.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/configuring/proc-creating-logging-filters.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/configuring/proc-creating-logging-filters.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/configuring/proc-creating-logging-filters.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/configuring/proc-creating-logging-filters.adoc
Outdated
Show resolved
Hide resolved
…ng examples Signed-off-by: prmellor <[email protected]>
Thanks for considering how to make the content clearer @scholzj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more nits, but LGTM otherwise. I already approved it.
documentation/modules/configuring/proc-creating-logging-filters.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/configuring/proc-creating-logging-filters.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a nit from me (and of course agree with the ones raised by Jakub)
documentation/api/io.strimzi.api.kafka.model.bridge.KafkaBridgeSpec.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: prmellor <[email protected]>
Documentation
Updates the logging content to reflect new support and Kafka 4.0 adoption of log4j2
Checklist
Please go through this checklist and make sure all applicable tasks have been done