Store CA generation in Ca class #11277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
im-konge
approved these changes
Mar 24, 2025
* Store CA generation directly in Ca class * Simplify getter methods * Remove duplicate methods from ReconcilerUtils Signed-off-by: Katherine Stanley <[email protected]>
katheris
force-pushed
the
refactorCaGenerationMethods
branch
from
46e3d17 to
8a90ba5
Compare
|
Thanks for the reviews everyone, I'm actually going to mark this as [Do Not Merge] as I'm working on a follow up refactor and want to make sure that these changes fully work with the follow up PR before merging. |
katheris
changed the title
Signed-off-by: Katherine Stanley <[email protected]>
katheris
changed the title
|
@ppatierno @tinaselenge @im-konge I've pushed a commit with a couple of small changes to better align this with a future refactor I will need to do. Please take another look when you get time |
im-konge
approved these changes
Apr 1, 2025
tinaselenge
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Refactoring CA generation methods in Ca class:
This change stores the CA generation in a variable, rather than relying on the generation inside the Secret class. This will help with future refactoring for cert-manager integration that will remove the direct use of the Secret in this class. It also simplifies the code, making it easier to follow.
Finally there was a duplicate method in ReconcilerUtils for determining if the CA generation changed, so this method has been removed and the code updated to use the method in the Ca class.
Checklist
Please go through this checklist and make sure all applicable tasks have been done