Skip to content

Fix multi-module release_package#8

Merged
see-quick merged 4 commits into
strimzi:mainfrom
see-quick:fix-release-package
May 29, 2026
Merged

Fix multi-module release_package#8
see-quick merged 4 commits into
strimzi:mainfrom
see-quick:fix-release-package

Conversation

@see-quick

@see-quick see-quick commented May 18, 2026

Copy link
Copy Markdown
Member

This PR fixes how we use release_package. Currently, makefile assumed single JAR at root but in this case as we are using multi-module we have jar in each of this directories instead of root target dir.

Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick see-quick self-assigned this May 18, 2026
@see-quick see-quick added this to the 0.1.0 milestone May 18, 2026
Signed-off-by: see-quick <maros.orsak159@gmail.com>
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@see-quick

Copy link
Copy Markdown
Member Author

Please take a look @strimzi/maintainers .

@see-quick see-quick linked an issue May 18, 2026 that may be closed by this pull request
@see-quick see-quick requested a review from a team May 20, 2026 11:27

@scholzj scholzj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to have some dedicated Maven module to assemble the connectors and pack them into a single archive?

@scholzj scholzj requested a review from Frawless May 20, 2026 11:48
@see-quick

see-quick commented May 20, 2026

Copy link
Copy Markdown
Member Author

Would it be better to have some dedicated Maven module to assemble the connectors and pack them into a single archive?

Currently this 6 LOC is doing exactly that. It copies each jars into release directory (i.e., target/release/) and then pack them into single archive which looks like this:

 strimzi-test-connectors-0.1.0-SNAPSHOT.tar.gz/zip
   \── fault-injection-source-connector-0.1.0-SNAPSHOT.jar
   \── another-one-connnector-0.1.0-SNAPSHOT.jar
   \── another-one-connector-2-0.1.0-SNAPSHOT.jar

I am not 100% sure I see the benefit of having a separate Maven module here, but I am open to change it if we think it would be good.

Update (for better handling in the test-container-images) it would have this format:

 strimzi-test-connectors-0.1.0-SNAPSHOT.tar.gz // (or .zip)
  ├── fault-injection-source-connector/
  │   └── fault-injection-source-connector-0.1.0-SNAPSHOT.jar
  ├── another-one-connnector/
  │    └── another-one-connnector-0.1.0-SNAPSHOT.jar
  └── another-one-connnector-2/
       └── another-one-connector-2-0.1.0-SNAPSHOT.jar

so then I can easily put it inside connector_plugins/

…ner-images

Signed-off-by: see-quick <maros.orsak159@gmail.com>
@Frawless

Copy link
Copy Markdown
Member

I think it might be more readable to have separated module that will pack the jars into one zip. Overall the output will be the same, but it could be harder to read the makefile. Also there might be some benefit to have it as output from mvn directly?

@see-quick

Copy link
Copy Markdown
Member Author

I think it might be more readable to have separated module that will pack the jars into one zip. Overall the output will be the same, but it could be harder to read the makefile. Also there might be some benefit to have it as output from mvn directly?

Okay, I will create separate Maven module then, thanks.

Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick

Copy link
Copy Markdown
Member Author

Created separated module for distributions using assembly-plugin let me know what you think. Thanks.

@scholzj scholzj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@see-quick see-quick merged commit 5f919d7 into strimzi:main May 29, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

release_package fails in multi-module Maven build

4 participants