Fix multi-module release_package#8
Conversation
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
|
Please take a look @strimzi/maintainers . |
scholzj
left a comment
There was a problem hiding this comment.
Would it be better to have some dedicated Maven module to assemble the connectors and pack them into a single archive?
Currently this 6 LOC is doing exactly that. It copies each jars into release directory (i.e., strimzi-test-connectors-0.1.0-SNAPSHOT.tar.gz/zip
\── fault-injection-source-connector-0.1.0-SNAPSHOT.jar
\── another-one-connnector-0.1.0-SNAPSHOT.jar
\── another-one-connector-2-0.1.0-SNAPSHOT.jarI am not 100% sure I see the benefit of having a separate Maven module here, but I am open to change it if we think it would be good. Update (for better handling in the test-container-images) it would have this format: strimzi-test-connectors-0.1.0-SNAPSHOT.tar.gz // (or .zip)
├── fault-injection-source-connector/
│ └── fault-injection-source-connector-0.1.0-SNAPSHOT.jar
├── another-one-connnector/
│ └── another-one-connnector-0.1.0-SNAPSHOT.jar
└── another-one-connnector-2/
└── another-one-connector-2-0.1.0-SNAPSHOT.jarso then I can easily put it inside |
…ner-images Signed-off-by: see-quick <maros.orsak159@gmail.com>
|
I think it might be more readable to have separated module that will pack the jars into one zip. Overall the output will be the same, but it could be harder to read the makefile. Also there might be some benefit to have it as output from mvn directly? |
Okay, I will create separate Maven module then, thanks. |
Signed-off-by: see-quick <maros.orsak159@gmail.com>
|
Created separated module for distributions using assembly-plugin let me know what you think. Thanks. |
This PR fixes how we use release_package. Currently, makefile assumed single JAR at root but in this case as we are using multi-module we have jar in each of this directories instead of root target dir.