Hardcode LegacyEphemeralKey and CustomerSession invariants as class-body overrides#12619
Draft
cttsai-stripe wants to merge 2 commits intomasterfrom
Draft
Hardcode LegacyEphemeralKey and CustomerSession invariants as class-body overrides#12619cttsai-stripe wants to merge 2 commits intomasterfrom
cttsai-stripe wants to merge 2 commits intomasterfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Committed-By-Agent: claude
Contributor
|
Diffuse output: APK |
- Add blank lines between commented property overrides in LegacyEphemeralKey (detekt spacing) - Update test fixtures to use CustomerSession when non-default saveConsent or removePaymentMethod values are needed, since LegacyEphemeralKey now hardcodes these - Consolidate two CustomerMetadataTest cases for LegacyEphemeralKey remove permissions into one that verifies the invariant (always Full) - Remove unused imports and parameters flagged by detekt Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Committed-By-Agent: claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CustomerMetadata.LegacyEphemeralKeyandCustomerMetadata.CustomerSessionLegacyEphemeralKey:removePaymentMethod(alwaysFull),saveConsent(alwaysLegacy), andcanUpdateFullPaymentMethodDetails(alwaysfalse) are now body overrides instead of constructor paramsCustomerSession:canUpdateFullPaymentMethodDetails(alwaystrue) is now a body override instead of a constructor paramcreateForCustomerSheetfactory to align — theLegacyEphemeralKeybranch now only passesid,ephemeralKeySecret,isPaymentMethodSetAsDefaultEnabled, andcanRemoveLastPaymentMethodThese values were already invariant in production — both the PaymentSheet and CustomerSheet paths always produced the same values for these fields. Making them structural enforces correctness and simplifies construction.
Follows the same pattern established for
CheckoutSessionin #12581.Test plan
./gradlew :paymentsheet:compileDebugKotlin :paymentsheet:compileDebugUnitTestKotlinpasses🤖 Generated with Claude Code