Skip existingPaymentMethodRequired in Google Pay test mode#13309
Open
seanzhang-stripe wants to merge 1 commit into
Open
Skip existingPaymentMethodRequired in Google Pay test mode#13309seanzhang-stripe wants to merge 1 commit into
seanzhang-stripe wants to merge 1 commit into
Conversation
In test mode, Google's isReadyToPay API can return false even when the user has joined the googlepay-test-mode-stub-data group, because the check requires an existing payment method in the wallet. This makes local testing impossible without adding a real card. This change skips the existingPaymentMethodRequired constraint and the loadPaymentData readiness check when the environment is Test, allowing developers to test Google Pay flows without a real card in their wallet. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Committed-By-Agent: claude
|
|
||
| suspend fun loadPaymentData(): Task<PaymentData> { | ||
| check(isReadyToPay()) { | ||
| check(args.config.environment == GooglePayEnvironment.Test || isReadyToPay()) { |
Contributor
There was a problem hiding this comment.
I don't love this. The behaviour is now different from GooglePayLauncherViewModel. I also don't see any tests for this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committed-By-Agent: claude
Summary
This change skips the
existingPaymentMethodRequiredconstraint and theloadPaymentDatareadiness check when the environment is Test, allowing developers to test Google Pay flows without a real card in their wallet.Motivation
Testing
Screenshots
Changelog