Skip to content

[onelink] Clean up use of interpolated brand strings#13318

Draft
mindy-stripe wants to merge 2 commits into
masterfrom
mindy/onelink-cleanup
Draft

[onelink] Clean up use of interpolated brand strings#13318
mindy-stripe wants to merge 2 commits into
masterfrom
mindy/onelink-cleanup

Conversation

@mindy-stripe

Copy link
Copy Markdown
Contributor

Summary

Need to get latest strings for these values:

In paymentsheet/res, the missing branded strings are:
stripe_sign_out_with_brand
Present only in base paymentsheet/res/values/strings.xml:273. Missing from every localized paymentsheet/res/values-*/strings.xml file, i.e. all 40 locale directories:
b+es+419, ca-rES, cs-rCZ, da, de, el-rGR, en-rGB, es, et-rEE, fi, fil, fr-rCA, fr, hr, hu, in, it, ja, ko, lt-rLT, lv-rLV, ms-rMY, mt, nb, nl, pl-rPL, pt-rBR, pt-rPT, ro-rRO, ro, ru,
sk-rSK, sl-rSI, sv, th, tr, vi, zh-rHK, zh-rTW, zh.

paymentsheet/res/values-zh-rTW/strings.xml
This locale is also missing these 9 branded keys:

  • stripe_pay_with_link_with_brand
  • stripe_sign_up_terms_alternative_with_phone_number_branded
  • stripe_sign_up_terms_alternative_branded
  • stripe_sign_up_terms_branded
  • stripe_sign_up_terms_default_opt_in_branded
  • stripe_inline_sign_up_header_default_opt_in_with_brand
  • stripe_inline_sign_up_toggle_with_brand
  • stripe_link_sign_up_message_v2_with_brand
  • stripe_paymentsheet_card_mandate_signup_toggle_on_v3_branded

Everything else from the target _with_brand / _branded set is present in the other locales. The practical blockers are:

  • stripe_sign_out_with_brand for the logout menu cleanup everywhere
  • the 9 zh-rTW misses for the remaining LinkButton, LinkTerms, and inline-header cleanup paths

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

@mindy-stripe mindy-stripe force-pushed the mindy/onelink-cleanup branch from 5d8c707 to caad66f Compare June 29, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant