Use latches in PaymentSheet load parallelism test#13327
Open
amk-stripe wants to merge 4 commits into
Open
Conversation
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
jaynewstrom-stripe
previously approved these changes
Jul 2, 2026
| Collections.synchronizedList(mutableListOf()) | ||
|
|
||
| private data class RequestEvent(val request: Request, val arrivalNanos: Long) | ||
| private lateinit var requestTracker: RequestTracker |
Collaborator
There was a problem hiding this comment.
Could this go into the "scenario"? I think we could add some methods on that to do some of the validations.
| try { | ||
| block() | ||
| } finally { | ||
| requestTracker.recordFinished(request) |
Collaborator
There was a problem hiding this comment.
This seems a little risky, should we add a catch + failed requests?
Collaborator
Author
There was a problem hiding this comment.
What's the risk you see? My understanding is that since there's no catch, the exception thrown in block() would still get thrown and lead to the test failing. The requestTracker.recordFinished just ensures that anything waiting on the finished CountDownLatch is unblocked if there's an exception thrown
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committed-By-Agent: codex
Summary
Use latches in PaymentSheet load parallelism test
Motivation
Make code easier to reason about and response to this code review comment: #13242 (comment)