Remove stale link module from translations job and harden empty-download guard#13359
Open
davidme-stripe wants to merge 1 commit into
Open
Remove stale link module from translations job and harden empty-download guard#13359davidme-stripe wants to merge 1 commit into
davidme-stripe wants to merge 1 commit into
Conversation
…oad guard Testing the tap-trust fix on a real runner revealed the next blocker: the `link` module was folded into `paymentsheet` back in #9771, but it was never removed from the localization MODULES list. It has no `link/res` directory in the repo, and Lokalise returns "No keys for export with current export settings" for it. With lokalise2 now installing correctly, that empty download tripped the new guard and aborted the whole job. - Remove the stale `link` entry from localization_vars.sh (its strings live in paymentsheet now). - Harden the guard so a module with no local `res/` directory is skipped with a warning instead of aborting, while a maintained module that unexpectedly returns no strings still aborts before any deletion. This keeps the anti-wipe protection while surviving future module cleanups. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Committed-By-Agent: claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the tap-trust fix (#13358). Testing that fix on a real runner (
workflow_dispatchrun28817910180) confirmed it works — lokalise2 now installs (Trusted tap: lokalise/cli-2, no more "Refusing to load"/"command not found") and downloads succeed — but it surfaced the next blocker.Problem
The run failed with:
The
linkmodule was folded intopaymentsheetin #9771 ("Move link into paymentsheet"), but it was never removed from the localizationMODULESlist. There's nolink/resdirectory in the repo and Lokalise returns no keys forlink/strings.xml. This was silently tolerated before (the old script skipped it, and more recently the whole job was failing on the lokalise2 install anyway); now that the install is fixed, the emptylinkexport trips the new guard and aborts the entire job.Fix
linkentry fromscripts/localization_vars.sh— its strings live inpaymentsheetnow.localize.sh: a module with no localres/directory is skipped with a warning (nothing to wipe), while a maintained module that unexpectedly returns no strings still aborts before any deletion. This preserves the anti-wipe protection while surviving future module cleanups.Verification
bash -npasses on both scripts.🤖 Generated with Claude Code