Draft
Conversation
mbroshi-stripe
requested review from
jar-stripe
and removed request for
a team
mbroshi-stripe
force-pushed
the
mbroshi/batch_jobs
branch
from
c9d94b9 to
11abe1c
Compare
mbroshi-stripe
force-pushed
the
mbroshi/batch_jobs
branch
2 times, most recently
from
e7e7d56 to
f8c52ad
Compare
mbroshi-stripe
force-pushed
the
mbroshi/batch_jobs
branch
from
f8c52ad to
3b722c6
Compare
prathmesh-stripe
approved these changes
Mar 24, 2026
| 'stripe_version' => $stripeVersion, | ||
| ]; | ||
| $item['path_params'] = ['account' => $account]; | ||
| $stripeContext = isset($opts->headers['Stripe-Context']) ? $opts->headers['Stripe-Context'] : null; |
Contributor
There was a problem hiding this comment.
small nit: move this variable assignment alongside $stripeVersion. In PHP 7+ they can be further reduced to use null coalescing and they'd be easier to read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
What?
See Also