Skip to content

run api generator after app is booted #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2019
Merged

run api generator after app is booted #411

merged 1 commit into from
Jul 30, 2019

Conversation

mrbatista
Copy link
Contributor

Description

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@mrbatista mrbatista mentioned this pull request Jul 9, 2019
Closed
@mrbatista mrbatista force-pushed the fix/support-boot-3 branch 3 times, most recently from af10918 to b9c7982 Compare July 9, 2019 16:15
bajtos
bajtos reviewed Jul 11, 2019
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mrbatista for the pull request ❤️

I have one comment to discuss & clarify, PTAL below.

@bajtos bajtos self-assigned this Jul 11, 2019
@bajtos bajtos added the bug label Jul 12, 2019
@mrbatista mrbatista force-pushed the fix/support-boot-3 branch from b9c7982 to fd18d3d Compare July 12, 2019 08:24
@mrbatista mrbatista force-pushed the fix/support-boot-3 branch from fd18d3d to 623752a Compare July 30, 2019 08:24
@mrbatista
Copy link
Contributor Author

@bajtos ping

@bajtos
Copy link
Member

bajtos commented Jul 30, 2019

LGTM 👍 The build failures look unrelated to your changes.

@bajtos bajtos merged commit f96cc9b into strongloop:master Jul 30, 2019
@bajtos
Copy link
Member

bajtos commented Jul 30, 2019

Landed, thank you for the contribution! ❤️

I have published the fix in [email protected], enjoy 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos approved these changes

@hacksparrow hacksparrow Awaiting requested review from hacksparrow hacksparrow is a code owner

@jannyHou jannyHou Awaiting requested review from jannyHou jannyHou is a code owner

@rashmihunt rashmihunt Awaiting requested review from rashmihunt rashmihunt is a code owner

Assignees

@bajtos bajtos

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrbatista @bajtos