Feat/core #8
Draft
Feat/core #8
+393
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertandrejev
force-pushed
the
feat/core
branch
from
b2a864b to
d189f3d
Compare
iamkunal9
reviewed
Nov 21, 2025
src/MaxBTCCore.sol
Outdated
| block.timestamp - lastUpdated < config.exchangeRateStalePeriod, | ||
| ExchangeRateStale() | ||
| ); | ||
| uint256 maxBTCToMint = (amount * 1e18) / exchangeRate; |
There was a problem hiding this comment.
The deposit() function doesn't normalize deposit amounts by token decimals before calculating mint amounts, which will cause massive over-minting when users deposit WBTC (8 decimals) or USDC (6 decimals).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.