Ignore missing / incomplete tiles if not strict decoding. #1616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this is related to #1448 |
fancycode
force-pushed
the
ignore-missing-tile-images
branch
from
3973e41 to
f0b68bb
Compare
Member
Author
|
In some cases the image doesn't exist yet, so I'm not sure how/where to store the warnings then. |
fancycode
force-pushed
the
ignore-missing-tile-images
branch
from
f0b68bb to
6c21e19
Compare
fancycode
force-pushed
the
ignore-missing-tile-images
branch
2 times, most recently
from
729a544 to
b33b6fc
Compare
Triggered by "fuzzing/data/corpus/clusterfuzz-testcase-minimized-file-fuzzer-5752063708495872.heic" and fuzzer.
fancycode
force-pushed
the
ignore-missing-tile-images
branch
from
b33b6fc to
e5fd2f6
Compare
Contributor
|
Is this still a draft? |
Member
Author
|
This is ready for review now. I didn't get any errors in my tests and fuzzing seems to be happy, too. |
fancycode
force-pushed
the
ignore-missing-tile-images
branch
from
0c25479 to
1499b4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I though about adding a dedicated flag but probably
strict_decodingis fine to use for these cases.Feel free to ping me for example images.