Fix usage of extname, dirname when there is no project path#1067
Open
rly wants to merge 1 commit intostyczynski:masterfrom
Open
Fix usage of extname, dirname when there is no project path#1067rly wants to merge 1 commit intostyczynski:masterfrom
rly wants to merge 1 commit intostyczynski:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #115 and all the many other duplicates.
When Atom is opened without a project,
atom.project.getPaths()[0]is undefined and raises an error in the Atom deprecation cop. Return@userHomein this case. Do not return null because functions downstream ofgetCwdexpect a string.