Fix garmin tts parsing (fixed DCO) #95
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotanalon
force-pushed
the
alon/fix_garmin_tts_parse
branch
from
da72b0e to
92298ce
Compare
Signed-off-by: Alon Dotan <[email protected]>
dotanalon
force-pushed
the
alon/fix_garmin_tts_parse
branch
from
92298ce to
a1f42e3
Compare
Member
|
@dotanalon: This is the same fix as what you had proposed in #94, which you then closed before opening this. If you want to discuss any more you can re-open #94 and implement the changes requested. |
Author
|
Unfortunately I cant reopen it, what do you suggest to do?
…On Sun, Dec 14, 2025 at 11:02 AM Michael Keller ***@***.***> wrote:
*mikeller* left a comment (subsurface/libdc#95)
<#95 (comment)>
@dotanalon <https://github.com/dotanalon>: This is the same fix as what
you had proposed in #94 <#94>,
which you then closed before opening this. If you want to discuss any more
you can re-open #94 <#94> and
implement the changes requested.
Please refrain from opening more unneeded pull requests.
—
Reply to this email directly, view it on GitHub
<#95 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABHF6ZPFJBMITM3AZ7QLDFL4BURUBAVCNFSM6AAAAACO7IVLC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNJQGUYDSMZWGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.