-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: add GIF support check in media block #4710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add GIF support check in media block #4710
Conversation
✅ All Jest tests passed! This PR is ready to merge. |
@Subham-KRLX try to add some demos like video or screenshots of the functionality that you achieved by this pr it's very helpful for reviewing!! |
Thanks for the quick feedback! I’ll add a demo screenshot or short video showcasing the .gif support in the media block shortly. Let me know if there’s anything specific you’d like to see in the demo! |
Hi @omsuneri, |
Hi @omsuneri, just checking in! All tests are passing and demo screenshots are added. Let me know if anything else is needed. 🙂 |
@Subham-KRLX please keep patience will review this soon |
@omsuneri Thanks for the update! I’ll keep this PR ready for your review. Quick note: I’ve prepared a screen recording demo and tested edge cases (large/animated GIFs) if needed. No rush—just confirming everything’s on standby. Appreciate your time!@omsuneri Thanks for the update! I’ll keep this PR ready for your review. |
This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the |
@omsuneri, Please review this pr. |
I tested your branch just now, and there is no new functionality that we didn't have before. With show and avatar blocks, the .gif image is displayed, but not animated.
On another note, why does this link to a non-existent page? |
Added logic to accept
.gif
files as valid media types in themedia.js
block.Changes
js/blocks/media.js
isSupportedMediaType()
that supports images and.gif
Test