Skip to content

Conversation

Subham-KRLX
Copy link

@Subham-KRLX Subham-KRLX commented Jun 14, 2025

Added logic to accept .gif files as valid media types in the media.js block.

Changes

  • Created js/blocks/media.js
  • Added isSupportedMediaType() that supports images and .gif
  • Test

  • Tested with file objects mimicking GIFs — passed.

Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@omsuneri
Copy link
Member

@Subham-KRLX try to add some demos like video or screenshots of the functionality that you achieved by this pr it's very helpful for reviewing!!

@Subham-KRLX
Copy link
Author

Thanks for the quick feedback! I’ll add a demo screenshot or short video showcasing the .gif support in the media block shortly. Let me know if there’s anything specific you’d like to see in the demo!

@Subham-KRLX
Copy link
Author

Hi @omsuneri,
Here's a quick demo screenshot showing .gif support working in the Media Block.
The .gif was successfully uploaded and appears on the stage as expected. Let me know if you'd like a video recording or exported project as well!

![Demo Screenshot]
WhatsApp Image 2025-06-14 at 11 45 20

@Subham-KRLX
Copy link
Author

Hi again 👋
As a follow-up to the earlier screenshot, here's a more detailed view of the .gif being used across multiple media blocks.
It confirms consistent rendering and integration.
Let me know if a video or exported project would also be helpful!
Screenshot 2025-06-14 at 11 47 18 AM

@Subham-KRLX
Copy link
Author

Hi @omsuneri, just checking in! All tests are passing and demo screenshots are added. Let me know if anything else is needed. 🙂

@omsuneri
Copy link
Member

@Subham-KRLX please keep patience will review this soon

@Subham-KRLX
Copy link
Author

@omsuneri Thanks for the update! I’ll keep this PR ready for your review.

Quick note: I’ve prepared a screen recording demo and tested edge cases (large/animated GIFs) if needed.

No rush—just confirming everything’s on standby. Appreciate your time!@omsuneri Thanks for the update! I’ll keep this PR ready for your review.

Copy link
Contributor

This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the stale label is removed or commented on.

@github-actions github-actions bot added the Stale label Aug 25, 2025
@Subham-KRLX
Copy link
Author

@omsuneri, Please review this pr.

@github-actions github-actions bot removed the Stale label Aug 26, 2025
@pikurasa
Copy link
Collaborator

I tested your branch just now, and there is no new functionality that we didn't have before. With show and avatar blocks, the .gif image is displayed, but not animated.

Quick note: I’ve prepared a screen recording demo and tested edge cases (large/animated GIFs) if needed.

On another note, why does this link to a non-existent page?

@pikurasa pikurasa closed this Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants