Initial multi-sample implementation #4738
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
1 similar comment
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
|
@AnvitaPrasad if you are changing the feature or functionality do rewrite the tests accordingly!! 😊 |
|
It isn't an issue while we debug this feature, but I am not sure about how we are managing samples here. I think we should impose a bit more structure to the sample files to simplify the code. Let's discuss. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.