fix: Upgrade jQuery from 2.1.4 to 3.7.1 #4767
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
Hi @walterbender, I’ve made the required changes in this PR. Kindly review it and let me know if any further modifications are needed. Thank you ! |
- Filter out deleted files from linting process - Prevents ESLint errors when files are removed in PR - Fixes jQuery upgrade PR linting failure
|
✅ All Jest tests passed! This PR is ready to merge. |
- Add || true to prevent workflow failure when no existing JS files found - Resolves exit code 123 error from xargs when all changed files are deleted - Ensures jQuery upgrade PR passes CI checks
|
✅ All Jest tests passed! This PR is ready to merge. |
- Add planet/libs/** to ignorePatterns to exclude jQuery libraries - Add **/*.min.js to ignore all minified files - Prevents ESLint errors on third-party libraries like jQuery 3.7.1 - Focuses linting on actual project code only
|
✅ All Jest tests passed! This PR is ready to merge. |
- Change lib/** to lib/jquery*.js to allow linting of lib/sw.js - Keep planet/libs/** and **/*.min.js patterns to ignore third-party files - Ensures only project files are linted, not external libraries - Fixes CI pipeline for jQuery upgrade PR
|
✅ All Jest tests passed! This PR is ready to merge. |
|
Hi @omsuneri, I’ve made the required changes in this PR. Kindly review it and let me know if any further modifications are needed. Thank you ! |
|
Beyond the unit tests, how else did you test this? Last time we tried, lots of things broke. |
|
Sir @walterbender, beyond unit tests I also performed manual testing on different browsers. I’ve attached a video showing the fix in action. If you’d like I can add some Cypress tests for the jQuery-dependent features as well. |
|
@walterbender Please review |
|
I cannot get search to work. Can you please investigate? |
2 participants
This PR upgrades jQuery from the outdated version 2.1.4 to the latest stable version 3.7.1, addressing critical security vulnerabilities and improving overall performance and compatibility.
Fixes: #4682
Changes Made:
Upgraded main application from jQuery 2.1.4 to 3.7.1
Upgraded planet module from jQuery 3.2.1 to 3.7.1
Updated service worker cache references
Removed legacy jQuery files to prevent version conflicts
VIDEO AFTER CHNAGES:
Recording.2025-09-22.193523.mp4