Detects Python 2 Activities_ fixes /sugar #991 #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chimosky
reviewed
Apr 7, 2025
| reply_handler=self._no_reply_handler, | ||
| error_handler=self._notify_launch_error_handler) | ||
|
|
||
| shell.NotifyLaunchFailure(activity_id, | ||
| reply_handler=reply_handler_cb, | ||
| error_handler=error_handler_cb) | ||
| error_handler=error_handler_cb) |
There was a problem hiding this comment.
Please remove the No new line at EOF, you can do so with echo >> activityfactory.py.
There was a problem hiding this comment.
Also see if you can figure out how it happened; we don't want unnecessary changes, it consumes reviewing time, and makes git bisect and git blame slightly more interesting than we can emotionally deal with.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in This PR
In sugar-toolkit-gtk3’s activityfactory.py, I’ve implemented:
Remaining Work
The following requirements are addressed in a separate PR in Sugar:
Reducing the launcher animation timeout to ~10 seconds.
Displaying error message in launcher.
Testing
Tested on Fedora 41 with Sugar 0.121.
Used calculate-activity(version 44) to verify:
The FileNotFoundError is caught and logged.
Notes
Please review the companion PR in the Sugar repo for the complete view of the fix.
@chimosky kindly review this.