Add 12/24 hour format with hours_fmt option and time_formatter #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
I included a very simple fix for #37
Included
hours_fmtoption tooptsandtime_formattermethod to handle formatting a date's time.This change really only adds ' AM' or ' PM' to the end of the timestamp and adjusts the hours portion appropriately if the user set
hours_fmt: 12when passing in options.I didn't touch the cases where Globalize exists. I assume that it would have its own way of handling this, but I haven't looked at it yet. I'm happy to include another commit to handle Globalize if need be.