♿️(frontend) fix accessible name of dropdown toggle button#379
Open
♿️(frontend) fix accessible name of dropdown toggle button#379
Conversation
Ovgodd
force-pushed
the
fix/select-dropdown-button-accessible-name
branch
from
46b03be to
62021da
Compare
Add aria-label and aria-hidden so SR announce the action, not icon name.
Ovgodd
force-pushed
the
fix/select-dropdown-button-accessible-name
branch
from
62021da to
b06198f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The screen reader was announcing the icon font name ("arrow_drop_down") as the accessible name of the dropdown toggle button instead of describing the action.
This change adds
aria-labelon the open/clear buttons andaria-hiddenon decorative iconsissue : https://github.com/suitenumerique/docs/issues/2009