♿(frontend) add missing label and fix Axes errors to improve a11y #1693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovgodd
changed the title
Ovgodd
force-pushed
the
fix/a11y-axe-errors
branch
2 times, most recently
from
d13f89f to
4d7b2cf
Compare
…hecks enhances a11y by adding label to fix axe tool errors on missing attributes Signed-off-by: Cyril <[email protected]>
Ovgodd
force-pushed
the
fix/a11y-axe-errors
branch
from
4d7b2cf to
b8a5e53
Compare
|
Size Change: +138 B (0%) Total Size: 4.11 MB
|
AntoLC
reviewed
Dec 5, 2025
Comment on lines
+88
to
+89
| aria-label={t(emoji ? 'Edit document emoji' : 'Add emoji')} | ||
| title={t(emoji ? 'Edit document emoji' : 'Add emoji')} |
Collaborator
There was a problem hiding this comment.
The parser cannot extract the translation if the ternaire is inside the t
Suggested change
| aria-label={t(emoji ? 'Edit document emoji' : 'Add emoji')} | |
| title={t(emoji ? 'Edit document emoji' : 'Add emoji')} | |
| aria-label={emoji ? t('Edit document emoji') : t('Add emoji')} | |
| title={emoji ? t('Edit document emoji') : t('Add emoji')} |
Collaborator
There was a problem hiding this comment.
There is cases where we cannot add emoji, so t('Add emoji') should not be everytime as a fallback, it depends if the user has the editing rights.
| editor={editor} | ||
| editable={false} | ||
| theme="light" | ||
| aria-label={t('Document viewer')} |
Collaborator
There was a problem hiding this comment.
You will not have any aria-label here so.
Comment on lines
+197
to
+233
| useEffect(() => { | ||
| if (!refEditorContainer.current) { | ||
| return; | ||
| } | ||
|
|
||
| const setEditorAriaAttributes = () => { | ||
| const editorElement = | ||
| refEditorContainer.current?.querySelector<HTMLElement>( | ||
| '.ProseMirror.bn-editor[contenteditable="true"]', | ||
| ); | ||
|
|
||
| if (!editorElement) { | ||
| return; | ||
| } | ||
|
|
||
| const label = t('Document editor'); | ||
|
|
||
| editorElement.setAttribute('aria-label', label); | ||
| editorElement.setAttribute('title', label); | ||
| }; | ||
|
|
||
| setEditorAriaAttributes(); | ||
|
|
||
| const observer = new MutationObserver(() => { | ||
| setEditorAriaAttributes(); | ||
| }); | ||
|
|
||
| observer.observe(refEditorContainer.current, { | ||
| childList: true, | ||
| subtree: true, | ||
| }); | ||
|
|
||
| return () => { | ||
| observer.disconnect(); | ||
| }; | ||
| }, [t]); | ||
|
|
Collaborator
There was a problem hiding this comment.
I find it is overkill to add all this code to have a aria-label and title.
Adding a title will impact the readibility as well:
Collaborator
There was a problem hiding this comment.
We now have a double scroll on the homepage, plus a kind of a fix position on the footer:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix several Axe accessibility issues (landmarks, button names, editor label, modals).
Proposal
/homeoutside of<main>socontentinfois a sibling landmark.aria-label/titleto icon-only buttons (e.g. document emoji) so they have discernible text.BlockNoteEditor, label the real editable node.ProseMirror.bn-edito and removearia-labelfromBlockNoteView`. s aDocShareModal.tsx