🐛(backend) strip whitespace from media URLs in CORS proxy#2004
Open
maboukerfa wants to merge 1 commit intosuitenumerique:mainfrom
Open
🐛(backend) strip whitespace from media URLs in CORS proxy#2004maboukerfa wants to merge 1 commit intosuitenumerique:mainfrom
maboukerfa wants to merge 1 commit intosuitenumerique:mainfrom
Conversation
When exporting a document to PDF, having whitespace before or after the media URL causes the image to not be downloaded via the CORS proxy, resulting in missing images in the exported PDF. Signed-off-by: Mohamed El Amine BOUKERFA <boukerfa.ma@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes an issue where media URLs with leading or trailing whitespace fail to download via the CORS proxy during PDF export, resulting in missing images in the exported PDF.
Screen.Recording.2026-03-15.at.16.18.45.mov
Proposal
Added
.strip()to the URL query parameter in the CORS proxy endpoint to handle URLs with accidental leading/trailing whitespace.