Skip to content

♿️(frontend) use semantic <p> elements in document info card #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ovgodd wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

♿️(frontend) use semantic <p> elements in document info card #2379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ and this project adheres to
- ♻️(frontend) move doc action buttons to fix toolbar #2360
- ♿️(frontend) add aria-hidden to decorative avatar SVGs in share modal #2324
- 🏗️(frontend) move comments to its own folder feature #2374
- ♿️(frontend) use semantic <p> elements in document info card #2379

### Fixed

Expand Down
6 changes: 4 additions & 2 deletions src/frontend/apps/impress/src/features/docs/doc-header/components/DocHeaderInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,19 +40,21 @@ export const DocHeaderInfo = ({ doc }: DocHeaderInfoProps) => {
}

return (
<Box $direction="row">
<Box $direction="row" $align="center">
<Text
as="p"
$variation="tertiary"
$size="s"
$weight="bold"
$theme={isEditable ? 'neutral' : 'warning'}
$direction="row"
$margin="0"
>
<VisibilityDoc doc={doc} />
{transRole(isEditable ? doc.user_role || doc.link_role : Role.READER)}
&nbsp;·&nbsp;
</Text>
<Text $variation="tertiary" $size="s">
<Text as="p" $variation="tertiary" $size="s" $margin="0">
{dateToDisplay}
</Text>
</Box>
Expand Down
Loading