Skip to content

✏️fix typo in backend and frontend #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

✏️fix typo in backend and frontend #947

wants to merge 2 commits into from

Conversation

Zorin95670
Copy link
Contributor

Purpose

Fix some typo on project.

@Zorin95670 Zorin95670 force-pushed the improvement/fix_typo branch 8 times, most recently from 3a265b2 to 31703b0 Compare May 7, 2025 14:06
@Zorin95670 Zorin95670 changed the title Improvement: fix typo in backend and frontend ✏️fix typo in backend and frontend May 7, 2025
@Zorin95670 Zorin95670 force-pushed the improvement/fix_typo branch from 31703b0 to 77394e9 Compare May 7, 2025 14:11
lunika
lunika reviewed May 9, 2025
View reviewed changes
Copy link
Member

@lunika lunika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also rebase your branch with the main branch ?

Thanks

CHANGELOG.md Outdated
Comment on lines 11 to 22
## Changed

- ✏️(backend) Fix some typo
- ✏️(frontend) Fix some typo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Changed
- ✏️(backend) Fix some typo
- ✏️(frontend) Fix some typo

This is not relevant in a changelog, can you remove it ? Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branch is rebase :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main Workflow / check-changelog (pull_request) failed because there's no changelog update.

However, @lunika, since you asked me to remove my changelog modification — is it okay like this, or should I add something back?

@Zorin95670 Zorin95670 force-pushed the improvement/fix_typo branch 2 times, most recently from f64af1c to 43df164 Compare May 12, 2025 08:44
@Zorin95670 Zorin95670 requested a review from lunika May 12, 2025 08:46
@Zorin95670 Zorin95670 force-pushed the improvement/fix_typo branch 4 times, most recently from ed799bb to 28f1ce9 Compare May 12, 2025 14:59
@virgile-dev
Copy link
Collaborator

Hey @Zorin95670 thanks for the contribution!
I'm not sure it will prevent from merging (it happenned to me in the past) but to avoid any issues make sure you follow the commit message format provided in the contributing.md.
Here I can see that you have caps in your commit message and no description aside from your signoff.
I don't see any test braking so we might have losen up the rule ;) (ping @lunika ?)

@Zorin95670 Zorin95670 force-pushed the improvement/fix_typo branch from 28f1ce9 to a61023c Compare May 13, 2025 07:54
@Zorin95670
Copy link
Contributor Author

Hi @virgile-dev, I’ve just repushed with an updated commit description. Sorry for the missing extra details earlier. I wasn’t sure they were relevant for this commit at first, but I’ve added them now!

Moittie Vincent added 2 commits May 13, 2025 09:58
@Zorin95670
✏️(backend) fix some typo
2e8c5b3 
Fix some typo in comments and documentation.

Signed-off-by: Zorin95670 <[email protected]>
@Zorin95670
✏️(frontend) fix some typo
7446840 
Fix some typo in comments, documentation and test description.

Signed-off-by: Zorin95670 <[email protected]>
@Zorin95670 Zorin95670 force-pushed the improvement/fix_typo branch from a61023c to 7446840 Compare May 13, 2025 07:59
@AntoLC AntoLC mentioned this pull request May 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunika lunika Awaiting requested review from lunika

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zorin95670 @virgile-dev @lunika