Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: undetermined string error #306

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: undetermined string error #306

wants to merge 1 commit into from

Conversation

psteinroe
Copy link
Collaborator

@psteinroe psteinroe commented Apr 4, 2025 •
edited
Loading

also cannot repro manually:
Screenshot 2025-04-04 at 11 33 01

@psteinroe psteinroe marked this pull request as draft April 4, 2025 09:35
@psteinroe psteinroe changed the title fix: try to reproJ fix: undetermined string error Apr 4, 2025
@psteinroe psteinroe mentioned this pull request Apr 4, 2025
Closed
2 tasks
juleswritescode
juleswritescode reviewed Apr 4, 2025
View reviewed changes
crates/pgt_lsp/tests/server.rs
server.open_document("").await?;

let chars = [
"C", "R", "E", "A", "T", "E", " ", "T", "A", "B", "L", "E", " ", "\"",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sanity check, do these need to be of char type? 'C', '"' etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juleswritescode juleswritescode

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psteinroe @juleswritescode