-
Notifications
You must be signed in to change notification settings - Fork 461
Snapchat OAuth Provider #1998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Snapchat OAuth Provider #1998
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution @ymiedviediev!
|
||
data := &UserProvidedData{} | ||
|
||
// Snapchat doesn't provide email by default, additional scopes needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
email is currently a requirement for the oauth login to succeed - what are the additional scopes required and can we add them to the default set above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snapchat OAuth mechanism does not expose user emails. The workaround over here right now is to imitate the email format by adding @snapchat.id to the user's external id, which is considered to be unique and identify the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ymiedviediev is snapchat.id a domain owned by snapchat? oauth users are allowed to initiate password recovery flows / email change which will result in an email link being sent to that email.
this would break those flows if a dummy value is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately the password recovery flow won't work for Snapchat OAuth integration, since email field is considered to be private information and is not part of the OAuth2 flow scopes.
b836a13
to
f782c9d
Compare
@kangmingtay When you have time, please look into this PR again 🙏 |
Pull Request Test Coverage Report for Build 15067614461Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
What kind of change does this PR introduce?
This introduces Snapchat OAuth2 provider for social login via Snapchat
What is the current behavior?
There is no possibility to login via Snapchat account
What is the new behavior?
Adding the functionality to login via snapchat as per official documentation:
Snap Login Kit Overview