Conversation
Pull Request Test Coverage Report for Build 21515862680Details
💛 - Coveralls |
ddcc147 to
c9d5fd0
Compare
| { | ||
| "datasource": { | ||
| "type": "prometheus", | ||
| "uid": "local_prometheus" | ||
| }, | ||
| "editorMode": "code", | ||
| "expr": "sum(increase(storage_api_otel_upload_started_total{region=~\"$region\", instance=~\"$instance\"}[$__range]))", | ||
| "hide": false, | ||
| "instant": false, | ||
| "legendFormat": "__auto", | ||
| "range": true, | ||
| "refId": "C" | ||
| } |
There was a problem hiding this comment.
This was supposed to be multipart I guess according to description but instead duplicates query A
| hostMetrics.start() | ||
|
|
||
| // Register Node.js runtime instrumentations | ||
| registerInstrumentations({ |
There was a problem hiding this comment.
I think we need to capture returned function unregister here to pass shutdown below. Otherwise, it might prevent process from exiting
There was a problem hiding this comment.
Thanks! I have double checked but this function is not returning anything.
I guess it registers it internally, and on stop, it will clean it up
There was a problem hiding this comment.
It returns a cleanup function, I believe we need to call it before meter shutdown for clean exit because it will stop timer for metric reader but won't touch the timer inside custom instrument. Another approach could be making timer unblocking as in #819 (comment)
c85a64a to
6bd7d5a
Compare
6bd7d5a to
2a88ed1
Compare
What kind of change does this PR introduce?
Feature
What is the current behavior?
Currently metrics are gathered using the prom-client and exposed to a metric endpoint
What is the new behavior?
ENABLE_PROMETHEUS_METRICS)Grafana dashboard
Running completely locally