Skip to content

fix: applying formatting to header/footer - #2904

Merged
harbournick merged 2 commits into
mainfrom
artem/SD-2618-v5
Apr 22, 2026
Merged

fix: applying formatting to header/footer#2904
harbournick merged 2 commits into
mainfrom
artem/SD-2618-v5

Conversation

@artem-harbour

@artem-harbour artem-harbour commented Apr 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Linear: SD-2618

Fixes inconsistent toolbar formatting in header/footer by removing stale selection restoration and avoiding deferred mark execution in H/F.

What changed

  • Skip restoreSelection() for header/footer toolbar interactions.
  • Execute mark-toggle commands immediately in header/footer (no pendingMarkCommands queue).
  • Simplify mark command selection resolution to use live transaction selection (tr.selection) via a centralized helper.
  • Clean up command call sites/signatures accordingly.
  • Add regression tests for:
    • no restoreSelection call in header/footer toolbar flow,
    • immediate (non-queued) mark-toggle execution in header/footer.

Result

  • bold/italic/underline/color/highlight now apply immediately in centered header/footer text.
  • fontFamily/fontSize now apply immediately without requiring an extra selection change.
  • Body behavior remains unchanged.

@linear

linear Bot commented Apr 22, 2026

Copy link
Copy Markdown

SD-2618 BUG: Header text styling changes do not apply in header/footer editor

@codecov-commenter

codecov-commenter commented Apr 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@artem-harbour artem-harbour self-assigned this Apr 22, 2026
@artem-harbour
artem-harbour marked this pull request as ready for review April 22, 2026 16:51
harbournick
harbournick approved these changes Apr 22, 2026
View reviewed changes

@harbournick harbournick left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harbournick
harbournick merged commit 75c8f51 into main Apr 22, 2026
16 checks passed
@harbournick
harbournick deleted the artem/SD-2618-v5 branch April 22, 2026 20:07
@superdoc-bot

superdoc-bot Bot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in @superdoc-dev/react v1.2.0-next.41

The release is available on GitHub release

@superdoc-bot

superdoc-bot Bot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in vscode-ext v2.3.0-next.43

@superdoc-bot

superdoc-bot Bot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in template-builder v1.6.0-next.6

The release is available on GitHub release

@superdoc-bot

superdoc-bot Bot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in esign v2.3.0-next.43

The release is available on GitHub release

@superdoc-bot

superdoc-bot Bot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in superdoc v1.28.0-next.6

The release is available on GitHub release

@superdoc-bot

superdoc-bot Bot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in superdoc-cli v0.8.0-next.6

The release is available on GitHub release

@superdoc-bot

superdoc-bot Bot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in superdoc-sdk v1.6.0-next.42

@superdoc-bot

superdoc-bot Bot commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in superdoc v1.29.0

The release is available on GitHub release

@superdoc-bot

superdoc-bot Bot commented Apr 25, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in @superdoc-dev/mcp v0.3.0-next.1

The release is available on GitHub release

@superdoc-bot

superdoc-bot Bot commented Apr 25, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in superdoc-sdk v1.8.0-next.1

@superdoc-bot

superdoc-bot Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in esign v2.6.0

The release is available on GitHub release

@superdoc-bot

superdoc-bot Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in template-builder v1.7.0

The release is available on GitHub release

@superdoc-bot

superdoc-bot Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in superdoc-cli v0.8.0

The release is available on GitHub release

@superdoc-bot

superdoc-bot Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in superdoc-sdk v1.8.0

@superdoc-bot

superdoc-bot Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in @superdoc-dev/mcp v0.3.0

The release is available on GitHub release

@superdoc-bot

superdoc-bot Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in vscode-ext v2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harbournick harbournick harbournick approved these changes
@VladaHarbour VladaHarbour Awaiting requested review from VladaHarbour
@caio-pizzol caio-pizzol Awaiting requested review from caio-pizzol

Assignees

@artem-harbour artem-harbour

Labels

released on @latest released on @next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@artem-harbour @codecov-commenter @harbournick