Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
ggdaltoso
force-pushed
the
feat/register-chart-feature-module
branch
3 times, most recently
from
June 5, 2026 23:33
132b52e to
ffc85c5
Compare
ggdaltoso
force-pushed
the
feat/register-chart-feature-module
branch
from
June 10, 2026 18:54
ffc85c5 to
7f8ba18
Compare
This commit introduces a new rendering feature for various types of charts in the feature registry. The new entry includes support for bar, line, stock, area, scatter, bubble, radar, pie, doughnut, and of pie charts, along with the corresponding module and specification reference.
This module renders DrawingML chart blocks as inline SVG elements, supporting various chart types with performance guardrails in place.
Updated the import path for the chart rendering function to point to the new features directory structure.
This commit introduces smoke tests to verify that all exports are correctly re-exported through the feature barrel and that the module handles every registered chart type without throwing or returning a generic placeholder. Full rendering correctness is covered by chart-renderer.test.ts.
ggdaltoso
force-pushed
the
feat/register-chart-feature-module
branch
from
June 23, 2026 18:14
7f8ba18 to
491f868
Compare
Contributor
|
Thanks for the thoughtful contribution, Gabriel! Making the chart renderer easier to discover is a useful DX improvement. We verified that this organization gap still exists in V2, and we’d like to carry your work forward on main through the internal mirror. |
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
superdoc-bot Bot
pushed a commit
that referenced
this pull request
Sep 13, 2026
![superdoc-oss-port[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
#50) * feat(chart): add rendering feature for DrawingML charts This commit introduces a new rendering feature for various types of charts in the feature registry. The new entry includes support for bar, line, stock, area, scatter, bubble, radar, pie, doughnut, and of pie charts, along with the corresponding module and specification reference. * feat(chart): add rendering feature module for DrawingML charts This module renders DrawingML chart blocks as inline SVG elements, supporting various chart types with performance guardrails in place. * feat(chart): update chart rendering import path Updated the import path for the chart rendering function to point to the new features directory structure. * test(chart): add smoke tests for chart feature module public API This commit introduces smoke tests to verify that all exports are correctly re-exported through the feature barrel and that the module handles every registered chart type without throwing or returning a generic placeholder. Full rendering correctness is covered by chart-renderer.test.ts. --------- Co-authored-by: ggdaltoso <ggdaltoso@gmail.com> Ported-From-Source-Repo: superdoc/orbit Ported-From-Source-Commit: 1851b21fb7bbd1d685a5490686d9e4c36dbdcabe Ported-Public-Prefix: superdoc/public
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been studying the codebase and noticed that
chart-renderer.tswas already living in its own file but wasn't registered infeature-registry.ts, unlikeinline-directionandmath, which follow the feature module pattern described inCLAUDE.md.This PR wires it up. No logic was changed; just the import path in
renderer.tsnow goes through the feature barrel, and charts are finally discoverable via the registry.(Genuinely impressed by how well-documented and thought-through the architecture is, btw. Learned a lot just reading through it!)