Skip to content

Fix plugin logos and recent rows for saved OpenClaw/Hermes memories#1054

Merged
MaheshtheDev merged 1 commit into
mainfrom
fix/plugin
Jun 6, 2026
Merged

Fix plugin logos and recent rows for saved OpenClaw/Hermes memories#1054
MaheshtheDev merged 1 commit into
mainfrom
fix/plugin

Conversation

@ved015
Copy link
Copy Markdown
Member

@ved015 ved015 commented Jun 5, 2026

This fixes plugin attribution for memories saved inside plugin spaces like OpenClaw and Hermes.

Previously, some saved memories showed up as plain generic notes even though they belonged to a plugin space. This happened mostly for memories saved directly through a save tool, because those notes did not always have the transcript-style content that the frontend parser expected.

Also fixes Recents section on main dashboard to render all plugins

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 92c71f2 Commit Preview URL

Branch Preview URL
Jun 05 2026, 04:29 PM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Jun 5, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 92c71f2 Jun 05 2026, 04:32 PM

@graphite-app graphite-app Bot requested a review from Dhravya June 5, 2026 16:29
@claude
Copy link
Copy Markdown

claude Bot commented Jun 5, 2026

Claude finished @ved015's task in 1m 47s —— View job


Review Complete

  • Get PR diff and understand changes
  • Read changed files and surrounding code
  • Check for existing review comments
  • Analyze for bugs, security issues, and logic errors
  • Submit review

Summary: Reviewed the changes for plugin attribution fallback logic. The code correctly adds space-based plugin detection as a fallback when metadata-based detection doesn't apply. No bugs, security issues, or logic errors found. Score: 10/10 — ready to ship.

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds fallback detection for plugin attribution via space container tags, ensuring memories saved directly through plugin tools get proper plugin logos and appear in the Recents section.

Issues found: None — this looks good to ship.

The changes are well-structured:

  • getPluginClientFromSpace correctly iterates container tags and memory space tags to detect plugin ownership
  • The new loop in parseToolUsage (lines 713-731) properly creates plugin entries for documents that exist in latestDocPerPlugin but don't have corresponding API key entries, and the subsequent loop (733-744) correctly fills in document info
  • parsePluginSpaceNote provides appropriate fallback parsing for plugin documents that don't match transcript patterns
  • All fallback placements are correct — more specific checks run first before these new generic space-based detections

Score: 10/10

@MaheshtheDev MaheshtheDev merged commit 1b1bd4d into main Jun 6, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants