Skip to content

test: setting session cookies #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 23, 2025
Merged

test: setting session cookies #1006

merged 3 commits into from
Jul 23, 2025

Conversation

namsnath
Copy link
Contributor

  • Adds support for token transfer method
  • Adds route for createNewSession

Summary of change

(A few sentences about this PR)

Related issues

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/configUtils.ts file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the add-ts-no-check.js file to include that
  • If added a new recipe / api interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If added a new recipe, then make sure to expose it inside the recipe folder present in the root of this repo. We also need to expose its types.
  • If added a new entry point, then make sure that it is importable by adding it to the exports in package.json

Remaining TODOs for this PR

  • Item1
  • Item2

@namsnath namsnath self-assigned this Jun 11, 2025
@namsnath namsnath requested a review from porcellus June 11, 2025 12:42
Copy link

promptless bot commented Jun 11, 2025

✅ No documentation updates required.

Copy link

cloudflare-workers-and-pages bot commented Jun 11, 2025

Deploying supertokens-node-pr-check-for-edge-function-compat with  Cloudflare Pages  Cloudflare Pages

Latest commit: 80fb310
Status: ✅  Deploy successful!
Preview URL: https://0741887a.supertokens-node-b95.pages.dev

View logs

@porcellus porcellus changed the base branch from 22.1 to 23.0 June 27, 2025 10:25
namsnath added 3 commits July 3, 2025 15:37
- Adds support for token transfer method
- Adds route for `createNewSession`
@namsnath namsnath force-pushed the test/session-cookie-setting branch from 700b8cd to 80fb310 Compare July 3, 2025 10:08
@namsnath namsnath requested a review from porcellus July 3, 2025 10:08
@porcellus porcellus merged commit 291bf09 into 23.0 Jul 23, 2025
321 of 323 checks passed
@porcellus porcellus deleted the test/session-cookie-setting branch July 23, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants