-
Notifications
You must be signed in to change notification settings - Fork 43
update: publish docs workflow #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 0.30
Are you sure you want to change the base?
Conversation
✅ No documentation updates required. |
steps: | ||
- uses: actions/checkout@v4 | ||
with: | ||
ref: ${{ inputs.branch }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow is triggered by pull request events, but inputs.branch
is undefined in this context since there are no workflow inputs defined. To properly reference the PR branch being built, use github.head_ref
or github.event.pull_request.head.ref
instead. For example:
ref: ${{ github.head_ref }}
This ensures the workflow checks out the correct branch that contains the changes being tested in the pull request.
ref: ${{ inputs.branch }} | |
ref: ${{ github.head_ref }} |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
mkdir -p $pythonDocDir/${{ needs.setup.outputs.versionFolder }} | ||
cp -r supertokens-python/html/* $pythonDocDir/${{ needs.setup.outputs.versionFolder }} | ||
|
||
if [[ "true" == "true" ]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition [[ "true" == "true" ]]
will always evaluate to true, making this conditional block execute unconditionally. If the intention is to conditionally execute this code based on whether the version is the latest, consider replacing this with [[ "${{ needs.setup.outputs.isLatest }}" == "true" ]]
or another appropriate variable. If this code should always run, the conditional check can be removed entirely for clarity.
if [[ "true" == "true" ]] | |
if [[ "${{ needs.setup.outputs.isLatest }}" == "true" ]] |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Summary of change
(A few sentences about this PR)
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.json
file has been updated (if needed)supertokens_python/constants.py
frontendDriverInterfaceSupported.json
file has been updated (if needed)setup.py
supertokens_python/constants.py
git tag
) in the formatvX.Y.Z
, and then find the latest branch (git branch --all
) whoseX.Y
is greater than the latest released tag.supertokens_python/utils.py
file to include that in theFRAMEWORKS
variablesyncio
/asyncio
functions are consistent.tests/sessions/test_access_token_version.py
to account for any new claims that are optional or omitted by the coreRemaining TODOs for this PR