-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Added batch downloading #5501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Added batch downloading #5501
Conversation
Signed-off-by: Piotr Danecki <[email protected]>
I found a horrible bug. Switching to a draft. |
Signed-off-by: Piotr Danecki <[email protected]>
Fixed |
<stkgui> | ||
<div x="1%" y="0" width="98%" layout="horizontal-row" height="9%"> | ||
<icon-button id="back" height="100%" icon_align="left" icon="gui/icons/back.png"/> | ||
<spacer proportion="0.1" height="1"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stick to using integers for GUI proportions. You can change the value for other elements if needed to achieve desired relative proportions.
Being able to download multiple addons without having to manually open a new dialog for every single one of them is definitely a useful QoL feature. However, even with the featured filter available, downloading all the listed addons is very crude, so I'm not sold on the current version of this PR. Also, this will probably lead to more people who have tons of addons they never use that just take up space. Of course this is the responsibility of the user more than of the game, but I see a line between making it easier and faster to get multiple addons and making it trivial to just download a few GBs worth of addons from the addons server. Finally, there is also the question of uninstalling. Having to go back to the extensions menu and searching for the extension you didn't like after testing it is rather unpractical as is. But if someone can install 200 addons with a few clicks, and then has a change of heart and needs to spend half-an-hour clicking to remove them, that's also an issue. Ideally, the user would be able to manually check/uncheck addons that will get downloaded, and to use the same selection tools to be able to mass uninstall addons. |
I'll get on it once I have time and energy. |
Agreement
This allow the user to automatically download all of the listed karts/tracks/arenas. This is useful with #5500 as the combination of this pr and that one allows the user to (for example) download all of the featured tracks, with just a single mouse press.
So far it seems to work, excluding the FIXME (mem-leak) and the icon-button doesn't working well with the mouse for some reason (high chance I messed up the .stkgui)
This is not vibe-coded, I just have a skill issue.