Skip to content

Conversation

Hanuko33
Copy link
Contributor

@Hanuko33 Hanuko33 commented Sep 9, 2025

Agreement

By creating a pull request in stk-code, you hereby agree to dual-license your contribution as
GNU General Public License version 3 or any later version and
Mozilla Public License version 2 or any later version.

This includes your previous contribution(s) under the same name of contributor.

Keep the above statement in the pull request comment for agreement.

This allow the user to automatically download all of the listed karts/tracks/arenas. This is useful with #5500 as the combination of this pr and that one allows the user to (for example) download all of the featured tracks, with just a single mouse press.

So far it seems to work, excluding the FIXME (mem-leak) and the icon-button doesn't working well with the mouse for some reason (high chance I messed up the .stkgui)

This is not vibe-coded, I just have a skill issue.

Signed-off-by: Piotr Danecki <[email protected]>
@Hanuko33 Hanuko33 changed the title Added batch downloading WIP: Added batch downloading Sep 11, 2025
@Hanuko33 Hanuko33 changed the title WIP: Added batch downloading Added batch downloading Sep 11, 2025
@Hanuko33 Hanuko33 marked this pull request as draft September 11, 2025 04:40
@Hanuko33
Copy link
Contributor Author

I found a horrible bug. Switching to a draft.
Dismiss frees the memory and then cancelled is being overwritten.
I didn't notice it during testing, because I was lucky (or unlucky) with the memory.

Signed-off-by: Piotr Danecki <[email protected]>
@Hanuko33
Copy link
Contributor Author

Fixed

@Hanuko33 Hanuko33 marked this pull request as ready for review September 14, 2025 11:57
<stkgui>
<div x="1%" y="0" width="98%" layout="horizontal-row" height="9%">
<icon-button id="back" height="100%" icon_align="left" icon="gui/icons/back.png"/>
<spacer proportion="0.1" height="1"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stick to using integers for GUI proportions. You can change the value for other elements if needed to achieve desired relative proportions.

@Alayan-stk-2
Copy link
Member

Being able to download multiple addons without having to manually open a new dialog for every single one of them is definitely a useful QoL feature.

However, even with the featured filter available, downloading all the listed addons is very crude, so I'm not sold on the current version of this PR.

Also, this will probably lead to more people who have tons of addons they never use that just take up space. Of course this is the responsibility of the user more than of the game, but I see a line between making it easier and faster to get multiple addons and making it trivial to just download a few GBs worth of addons from the addons server.

Finally, there is also the question of uninstalling. Having to go back to the extensions menu and searching for the extension you didn't like after testing it is rather unpractical as is. But if someone can install 200 addons with a few clicks, and then has a change of heart and needs to spend half-an-hour clicking to remove them, that's also an issue.

Ideally, the user would be able to manually check/uncheck addons that will get downloaded, and to use the same selection tools to be able to mass uninstall addons.

@Hanuko33
Copy link
Contributor Author

I'll get on it once I have time and energy.
Thanks for reviewing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants