chore(logger): move logger to internal #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## reboot #1979 +/- ##
==========================================
- Coverage 99.22% 97.09% -2.14%
==========================================
Files 3 4 +1
Lines 129 172 +43
==========================================
+ Hits 128 167 +39
- Misses 1 4 +3
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vprashar2929
force-pushed
the
chore-logger
branch
from
c95e74a to
78c7e7f
Compare
|
pre-commit failure is addressed in #1980 |
sthaha
reviewed
Apr 5, 2025
internal/logger/logger.go
Outdated
| @@ -24,7 +24,7 @@ import ( | |||
| "strings" | |||
| ) | |||
|
|
|||
| func setupLogger(level, format string) *slog.Logger { | |||
| func SetupLogger(level, format string) *slog.Logger { | |||
There was a problem hiding this comment.
Suggested change
| func SetupLogger(level, format string) *slog.Logger { | |
| func New(level, format string) *slog.Logger { |
vprashar2929
force-pushed
the
chore-logger
branch
from
78c7e7f to
5e892e5
Compare
sthaha
previously approved these changes
Apr 7, 2025
This commit moves logger to internal package. Follow up to sustainable-computing-io#1977 Signed-off-by: vprashar2929 <[email protected]>
vprashar2929
force-pushed
the
chore-logger
branch
from
5e892e5 to
578992d
Compare
sthaha
approved these changes
Apr 7, 2025
sthaha
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves logger to internal package.
Follow up to #1977