Fix linking error in CMake#137
Closed
jfsmig wants to merge 2 commits intosustrik:masterfrom
jfsmig:M-fix-build-with-tests
Closed
Fix linking error in CMake#137jfsmig wants to merge 2 commits intosustrik:masterfrom jfsmig:M-fix-build-with-tests
jfsmig wants to merge 2 commits intosustrik:masterfrom
jfsmig:M-fix-build-with-tests
Conversation
Contributor
Author
|
Sorry, the PR is incomplete at best (or makes no sense at worse), the cmake support needs a deeper review to reach the compatibility with configuration for the autotools (I didn't notice its clues). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #133 but only on the targets really requiring pthreads.
I submit this patch under the MIT/X11 license.